remove AUTHORS file and cleanup spec file

[libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

Posted by Pavel Hrdina 7 years, 10 months ago

This is tracked by git itself.  Suggested during fedora package review.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 AUTHORS.in           | 13 -------------
 Makefile.am          | 14 --------------
 libvirt-dbus.spec.in |  2 +-
 3 files changed, 1 insertion(+), 28 deletions(-)
 delete mode 100644 AUTHORS.in

diff --git a/AUTHORS.in b/AUTHORS.in
deleted file mode 100644
index 988dd6a..0000000
--- a/AUTHORS.in
+++ /dev/null
@@ -1,13 +0,0 @@
-       libvirt-dbus Authors
-       ====================
-
-The primary maintainers of libvirt-dbus are:
-
-    Lars Karlitski <lars@karlitski.net>
-    Pavel Hrdina <phrdina@redhat.com>
-
-Patches have been received from:
-
-#authorslist#
-
-   ... send patches to get your name added ...
diff --git a/Makefile.am b/Makefile.am
index a890ff1..0c792c1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -6,7 +6,6 @@ ACLOCAL_AMFLAGS = -I m4
 EXTRA_DIST = \
 	$(PACKAGE).spec \
 	$(PACKAGE).spec.in \
-	AUTHORS.in \
 	HACKING.md \
 	README.md \
 	$(NULL)
@@ -15,16 +14,3 @@ DISTCLEAN_FILES = $(PACKAGE).spec
 
 rpm: clean
 	@(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz)
-
-dist-hook: gen-AUTHORS
-
-# Generate the AUTHORS file (with all entries since the switch to git)
-# and insert it into the directory we're about to use to create a tarball.
-.PHONY: gen-AUTHORS
-gen-AUTHORS:
-	$(AM_V_GEN)if test -d $(srcdir)/.git; then                      \
-	  out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
-	  perl -p -e "s/#authorslist#// and print '$$out'"            \
-	    < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp &&        \
-	  mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ;           \
-	fi
diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in
index 1cf5922..3a04ad6 100644
--- a/libvirt-dbus.spec.in
+++ b/libvirt-dbus.spec.in
@@ -52,7 +52,7 @@ exit 0
 
 %files
 %defattr(-,root,root,-)
-%doc README.md HACKING.md COPYING AUTHORS NEWS
+%doc README.md HACKING.md COPYING NEWS
 %{_sysconfdir}/polkit-1/rules.d/libvirt-dbus.rules
 %{_bindir}/libvirt-dbus
 %{_datadir}/dbus-1/services/org.libvirt.service
-- 
2.14.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

Posted by Daniel P. Berrangé 7 years, 10 months ago

On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote:
> This is tracked by git itself.  Suggested during fedora package review.

AUTHORS is a file that autoconf/automake expects to exist in all
projects. Also the git history is not included with the tar.gz
dist, so IMHO the AUTHORS is appropriate to keep regardless.

> 
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
>  AUTHORS.in           | 13 -------------
>  Makefile.am          | 14 --------------
>  libvirt-dbus.spec.in |  2 +-
>  3 files changed, 1 insertion(+), 28 deletions(-)
>  delete mode 100644 AUTHORS.in
> 
> diff --git a/AUTHORS.in b/AUTHORS.in
> deleted file mode 100644
> index 988dd6a..0000000
> --- a/AUTHORS.in
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -       libvirt-dbus Authors
> -       ====================
> -
> -The primary maintainers of libvirt-dbus are:
> -
> -    Lars Karlitski <lars@karlitski.net>
> -    Pavel Hrdina <phrdina@redhat.com>
> -
> -Patches have been received from:
> -
> -#authorslist#
> -
> -   ... send patches to get your name added ...
> diff --git a/Makefile.am b/Makefile.am
> index a890ff1..0c792c1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -6,7 +6,6 @@ ACLOCAL_AMFLAGS = -I m4
>  EXTRA_DIST = \
>  	$(PACKAGE).spec \
>  	$(PACKAGE).spec.in \
> -	AUTHORS.in \
>  	HACKING.md \
>  	README.md \
>  	$(NULL)
> @@ -15,16 +14,3 @@ DISTCLEAN_FILES = $(PACKAGE).spec
>  
>  rpm: clean
>  	@(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz)
> -
> -dist-hook: gen-AUTHORS
> -
> -# Generate the AUTHORS file (with all entries since the switch to git)
> -# and insert it into the directory we're about to use to create a tarball.
> -.PHONY: gen-AUTHORS
> -gen-AUTHORS:
> -	$(AM_V_GEN)if test -d $(srcdir)/.git; then                      \
> -	  out="`cd $(srcdir) && git log --pretty=format:'%aN <%aE>' | sort -u`" && \
> -	  perl -p -e "s/#authorslist#// and print '$$out'"            \
> -	    < $(srcdir)/AUTHORS.in > $(distdir)/AUTHORS-tmp &&        \
> -	  mv -f $(distdir)/AUTHORS-tmp $(distdir)/AUTHORS ;           \
> -	fi
> diff --git a/libvirt-dbus.spec.in b/libvirt-dbus.spec.in
> index 1cf5922..3a04ad6 100644
> --- a/libvirt-dbus.spec.in
> +++ b/libvirt-dbus.spec.in
> @@ -52,7 +52,7 @@ exit 0
>  
>  %files
>  %defattr(-,root,root,-)
> -%doc README.md HACKING.md COPYING AUTHORS NEWS
> +%doc README.md HACKING.md COPYING NEWS
>  %{_sysconfdir}/polkit-1/rules.d/libvirt-dbus.rules
>  %{_bindir}/libvirt-dbus
>  %{_datadir}/dbus-1/services/org.libvirt.service
> -- 
> 2.14.3
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

Posted by Pavel Hrdina 7 years, 10 months ago

On Mon, Mar 26, 2018 at 02:56:06PM +0100, Daniel P. Berrangé wrote:
> On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote:
> > This is tracked by git itself.  Suggested during fedora package review.
> 
> AUTHORS is a file that autoconf/automake expects to exist in all
> projects. Also the git history is not included with the tar.gz

That is true only if the project decides to follow GNU standard, it
requires ChangeLog file which is not present.

> dist, so IMHO the AUTHORS is appropriate to keep regardless.

That is correct, however, if someone really wants to know who
contributed into the project and what was the contribution the AUTHORS
file will not provide you all these information and you will have to
look into the git repository.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

Posted by Daniel P. Berrangé 7 years, 10 months ago

On Mon, Mar 26, 2018 at 05:11:06PM +0200, Pavel Hrdina wrote:
> On Mon, Mar 26, 2018 at 02:56:06PM +0100, Daniel P. Berrangé wrote:
> > On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote:
> > > This is tracked by git itself.  Suggested during fedora package review.
> > 
> > AUTHORS is a file that autoconf/automake expects to exist in all
> > projects. Also the git history is not included with the tar.gz
> 
> That is true only if the project decides to follow GNU standard, it
> requires ChangeLog file which is not present.


> > dist, so IMHO the AUTHORS is appropriate to keep regardless.
> 
> That is correct, however, if someone really wants to know who
> contributed into the project and what was the contribution the AUTHORS
> file will not provide you all these information and you will have to
> look into the git repository.

If the git repository still exists, and is accessible, when you want to
look for it. Sadly there are many projects with no git repo anymore after
services like gitorious.org and code.google.com shutdown. Not that I'm
suggesting libvirt.org is going away any time soon, but no one can predict
10+ years into the future. IMHO, giving authors credit in the distributed
release tarballs is important, even if git or any other repo exists.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

Posted by Pavel Hrdina 7 years, 10 months ago

On Mon, Mar 26, 2018 at 04:22:02PM +0100, Daniel P. Berrangé wrote:
> On Mon, Mar 26, 2018 at 05:11:06PM +0200, Pavel Hrdina wrote:
> > On Mon, Mar 26, 2018 at 02:56:06PM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote:
> > > > This is tracked by git itself.  Suggested during fedora package review.
> > > 
> > > AUTHORS is a file that autoconf/automake expects to exist in all
> > > projects. Also the git history is not included with the tar.gz
> > 
> > That is true only if the project decides to follow GNU standard, it
> > requires ChangeLog file which is not present.
> 
> 
> > > dist, so IMHO the AUTHORS is appropriate to keep regardless.
> > 
> > That is correct, however, if someone really wants to know who
> > contributed into the project and what was the contribution the AUTHORS
> > file will not provide you all these information and you will have to
> > look into the git repository.
> 
> If the git repository still exists, and is accessible, when you want to
> look for it. Sadly there are many projects with no git repo anymore after
> services like gitorious.org and code.google.com shutdown. Not that I'm
> suggesting libvirt.org is going away any time soon, but no one can predict
> 10+ years into the future. IMHO, giving authors credit in the distributed
> release tarballs is important, even if git or any other repo exists.

OK, I can agree with this argument :).  I'll drop this patch.

Thanks,
Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [dbus PATCH 1/4] maint: remove AUTHORS from repository

Posted by Ján Tomko 7 years, 10 months ago

On Mon, Mar 26, 2018 at 03:33:50PM +0200, Pavel Hrdina wrote:
>This is tracked by git itself.  Suggested during fedora package review.
>
>Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
>---
> AUTHORS.in           | 13 -------------
> Makefile.am          | 14 --------------
> libvirt-dbus.spec.in |  2 +-
> 3 files changed, 1 insertion(+), 28 deletions(-)
> delete mode 100644 AUTHORS.in
>

ACK

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list