Hi,

This patch series adds Libvirt support for video and input devices 
for QEMU guests on S390. QEMU v2.11.0 added support for the 
virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet}-ccw devices [2], 
which can be used as video and input devices respectively.

Thanks
Farhan

[1] https://git.qemu.org/?p=qemu.git;a=commit;h=1f8ad88935f5cb5a2968909e392dbeee1a84b931
[2] https://git.qemu.org/?p=qemu.git;a=commit;h=3382cf1fabbf722dce931846853dae711838e720

ChangeLog
---------
v1 -> v2
    - Split virtio-gpu-ccw capability (patch 1) and functionality (patch 2)
      into 2 patches.

    - Code changes per John's comments (patch 2).

    - Split capability for input devices (patch 4) and functionality (patch 5)
      into 2 patches.

    - Modify news update as per John's suggestion (patch 7).


Farhan Ali (7):
  qemu: Introduce a new capability for virtio-gpu-ccw
  qemu: Add support for virtio-gpu-ccw video device on S390
  tests: Add test cases for virtio-gpu-ccw
  qemu: Introduce capabilities for virtio input ccw devices
  qemu: Add support for virtio input ccw devices
  tests: Add test case for virtio input ccw devices
  news: Update for virtio-gpu-ccw and virtio input ccw devices

 docs/formatdomain.html.in                          |  5 ++
 docs/news.xml                                      | 10 +++
 src/qemu/qemu_capabilities.c                       | 13 ++++
 src/qemu/qemu_capabilities.h                       |  6 ++
 src/qemu/qemu_command.c                            | 27 +++++--
 src/qemu/qemu_domain.c                             |  2 +-
 src/qemu/qemu_domain_address.c                     | 12 +++-
 src/qemu/qemu_process.c                            |  5 +-
 .../qemucapabilitiesdata/caps_2.11.0.s390x.replies | 83 +++++++++++++++++++---
 tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   |  6 +-
 tests/qemuxml2argvdata/input-virtio-ccw.args       | 26 +++++++
 tests/qemuxml2argvdata/input-virtio-ccw.xml        | 29 ++++++++
 .../qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml | 18 +++++
 tests/qemuxml2argvdata/video-virtio-gpu-ccw.args   | 25 +++++++
 tests/qemuxml2argvdata/video-virtio-gpu-ccw.xml    | 35 +++++++++
 tests/qemuxml2argvtest.c                           | 15 ++++
 tests/qemuxml2xmloutdata/input-virtio-ccw.xml      | 37 ++++++++++
 .../video-virtio-gpu-ccw-auto.xml                  | 35 +++++++++
 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw.xml  | 39 ++++++++++
 tests/qemuxml2xmltest.c                            | 22 ++++++
 20 files changed, 431 insertions(+), 19 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/input-virtio-ccw.args
 create mode 100644 tests/qemuxml2argvdata/input-virtio-ccw.xml
 create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw-auto.xml
 create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw.args
 create mode 100644 tests/qemuxml2argvdata/video-virtio-gpu-ccw.xml
 create mode 100644 tests/qemuxml2xmloutdata/input-virtio-ccw.xml
 create mode 100644 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw-auto.xml
 create mode 100644 tests/qemuxml2xmloutdata/video-virtio-gpu-ccw.xml

-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Mon, Mar 19, 2018 at 02:35:28PM -0400, Farhan Ali wrote:
>Hi,
>
>This patch series adds Libvirt support for video and input devices
>for QEMU guests on S390. QEMU v2.11.0 added support for the
>virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet}-ccw devices [2],
>which can be used as video and input devices respectively.
>
>Thanks
>Farhan
>
>[1] https://git.qemu.org/?p=qemu.git;a=commit;h=1f8ad88935f5cb5a2968909e392dbeee1a84b931
>[2] https://git.qemu.org/?p=qemu.git;a=commit;h=3382cf1fabbf722dce931846853dae711838e720
>
>ChangeLog
>---------
>v1 -> v2
>    - Split virtio-gpu-ccw capability (patch 1) and functionality (patch 2)
>      into 2 patches.
>
>    - Code changes per John's comments (patch 2).
>
>    - Split capability for input devices (patch 4) and functionality (patch 5)
>      into 2 patches.
>
>    - Modify news update as per John's suggestion (patch 7).
>
>
>Farhan Ali (7):
>  qemu: Introduce a new capability for virtio-gpu-ccw
>  qemu: Add support for virtio-gpu-ccw video device on S390
>  tests: Add test cases for virtio-gpu-ccw
>  qemu: Introduce capabilities for virtio input ccw devices
>  qemu: Add support for virtio input ccw devices
>  tests: Add test case for virtio input ccw devices
>  news: Update for virtio-gpu-ccw and virtio input ccw devices
>

Looks good to me. I have some nitpicks re: splitting the changes into
patches (which should also apply to the "input" part of the series)

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 03/22/2018 03:32 PM, Ján Tomko wrote:
> On Mon, Mar 19, 2018 at 02:35:28PM -0400, Farhan Ali wrote:
>> Hi,
>>
>> This patch series adds Libvirt support for video and input devices
>> for QEMU guests on S390. QEMU v2.11.0 added support for the
>> virtio-gpu-ccw device [1] and virtio-{keyboard, mouse, tablet}-ccw 
>> devices [2],
>> which can be used as video and input devices respectively.
>>
>> Thanks
>> Farhan
>>
>> [1] 
>> https://git.qemu.org/?p=qemu.git;a=commit;h=1f8ad88935f5cb5a2968909e392dbeee1a84b931 
>>
>> [2] 
>> https://git.qemu.org/?p=qemu.git;a=commit;h=3382cf1fabbf722dce931846853dae711838e720 
>>
>>
>> ChangeLog
>> ---------
>> v1 -> v2
>>    - Split virtio-gpu-ccw capability (patch 1) and functionality 
>> (patch 2)
>>      into 2 patches.
>>
>>    - Code changes per John's comments (patch 2).
>>
>>    - Split capability for input devices (patch 4) and functionality 
>> (patch 5)
>>      into 2 patches.
>>
>>    - Modify news update as per John's suggestion (patch 7).
>>
>>
>> Farhan Ali (7):
>>  qemu: Introduce a new capability for virtio-gpu-ccw
>>  qemu: Add support for virtio-gpu-ccw video device on S390
>>  tests: Add test cases for virtio-gpu-ccw
>>  qemu: Introduce capabilities for virtio input ccw devices
>>  qemu: Add support for virtio input ccw devices
>>  tests: Add test case for virtio input ccw devices
>>  news: Update for virtio-gpu-ccw and virtio input ccw devices
>>
> 
> Looks good to me. I have some nitpicks re: splitting the changes into
> patches (which should also apply to the "input" part of the series)
> 
> Jan

Thanks for reviewing :)

> 
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list