Add proper testing of qemu status XML files

[libvirt] [PATCH v2 01/10] tests: qemuxml2xml: Rename testInfoFree to testInfoClear

Posted by Peter Krempa 7 years, 11 months ago

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemuxml2xmltest.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index 0eb9e6c77a..2cbe0c82a7 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -278,7 +278,7 @@ testCompareStatusXMLToXMLFiles(const void *opaque)


 static void
-testInfoFree(struct testInfo *info)
+testInfoClear(struct testInfo *info)
 {
     VIR_FREE(info->inName);
     VIR_FREE(info->outActiveName);
@@ -345,7 +345,7 @@ testInfoSet(struct testInfo *info,
     return 0;

  error:
-    testInfoFree(info);
+    testInfoClear(info);
     return -1;
 }

@@ -404,7 +404,7 @@ mymain(void)
                             testCompareStatusXMLToXMLFiles, &info) < 0) \
                 ret = -1; \
         } \
-        testInfoFree(&info); \
+        testInfoClear(&info); \
     } while (0)

 # define NONE QEMU_CAPS_LAST
-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 01/10] tests: qemuxml2xml: Rename testInfoFree to testInfoClear

Posted by Jiri Denemark 7 years, 11 months ago

On Wed, Mar 07, 2018 at 15:42:27 +0100, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  tests/qemuxml2xmltest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

ACK

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list