qemu: Fix updating device with boot order

[libvirt] [PATCH 0/3] qemu: Fix updating device with boot order

Jiri Denemark posted 3 patches 6 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1519309259.git.jdenemar@redhat.com

Test syntax-check passed

src/conf/domain_conf.c | 30 ++++++++++++++++++++++-------
src/conf/domain_conf.h |  3 ++-
src/lxc/lxc_driver.c   | 18 +++++++++---------
src/qemu/qemu_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++----------
4 files changed, 75 insertions(+), 27 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] qemu: Fix updating device with boot order

Posted by Jiri Denemark 6 years, 2 months ago

Commit v3.7.0-14-gc57f3fd2f8 prevented adding a <boot order='x'/>
element to an inactive domain with global <boot dev='...'/> element.
However, as a result of that change updating any device with boot order
would fail with 'boot order X is already used by another device', where
"another device" is in fact the device which is being updated.

To fix this we have to ignore the device which we're about to update
when checking for boot order conflicts.

https://bugzilla.redhat.com/show_bug.cgi?id=1546971

Jiri Denemark (3):
  lxc: Drop useless check in live device update
  Pass oldDev to virDomainDefCompatibleDevice on device update
  qemu: Fix updating device with boot order

 src/conf/domain_conf.c | 30 ++++++++++++++++++++++-------
 src/conf/domain_conf.h |  3 ++-
 src/lxc/lxc_driver.c   | 18 +++++++++---------
 src/qemu/qemu_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++----------
 4 files changed, 75 insertions(+), 27 deletions(-)

-- 
2.16.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] qemu: Fix updating device with boot order

Posted by Michal Privoznik 6 years, 2 months ago

On 02/22/2018 03:21 PM, Jiri Denemark wrote:
> Commit v3.7.0-14-gc57f3fd2f8 prevented adding a <boot order='x'/>
> element to an inactive domain with global <boot dev='...'/> element.
> However, as a result of that change updating any device with boot order
> would fail with 'boot order X is already used by another device', where
> "another device" is in fact the device which is being updated.
> 
> To fix this we have to ignore the device which we're about to update
> when checking for boot order conflicts.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1546971
> 
> Jiri Denemark (3):
>   lxc: Drop useless check in live device update
>   Pass oldDev to virDomainDefCompatibleDevice on device update
>   qemu: Fix updating device with boot order
> 
>  src/conf/domain_conf.c | 30 ++++++++++++++++++++++-------
>  src/conf/domain_conf.h |  3 ++-
>  src/lxc/lxc_driver.c   | 18 +++++++++---------
>  src/qemu/qemu_driver.c | 51 ++++++++++++++++++++++++++++++++++++++++----------
>  4 files changed, 75 insertions(+), 27 deletions(-)
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list