qemu: Don't refresh 'halted' state for domain stats

[libvirt] [PATCH 0/4] qemu: Don't refresh 'halted' state for domain stats

Posted by Peter Krempa 6 years, 2 months ago

The halted state information is useless on most platforms and calling
'query-cpus' is very expensive. Don't report the info on platforms where
it does not make sense.

Peter Krempa (3):
  qemu: driver: Extract vcpu halted state directly
  qemu: Remove unused 'cpuhalted' argument from qemuDomainHelperGetVcpus
  qemu: domain: Store vcpu halted state as a tristate

Viktor Mihajlovski (1):
  qemu: Limit refresh of CPU halted state to s390

 src/qemu/qemu_domain.c |  8 +++++++-
 src/qemu/qemu_domain.h |  2 +-
 src/qemu/qemu_driver.c | 36 +++++++++++++++---------------------
 3 files changed, 23 insertions(+), 23 deletions(-)

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] qemu: Don't refresh 'halted' state for domain stats

Posted by Viktor Mihajlovski 6 years, 2 months ago

On 06.02.2018 16:30, Peter Krempa wrote:
> The halted state information is useless on most platforms and calling
> 'query-cpus' is very expensive. Don't report the info on platforms where
> it does not make sense.
> 
> Peter Krempa (3):
>   qemu: driver: Extract vcpu halted state directly
>   qemu: Remove unused 'cpuhalted' argument from qemuDomainHelperGetVcpus
>   qemu: domain: Store vcpu halted state as a tristate
> 
> Viktor Mihajlovski (1):
>   qemu: Limit refresh of CPU halted state to s390
> 
>  src/qemu/qemu_domain.c |  8 +++++++-
>  src/qemu/qemu_domain.h |  2 +-
>  src/qemu/qemu_driver.c | 36 +++++++++++++++---------------------
>  3 files changed, 23 insertions(+), 23 deletions(-)
> 
Hi Peter,

I was planning to pick up your tri-state proposal but you were quicker.
Series looks good to me. Refactoring the halted state retrieval is
probably the right thing do.

Thanks!

-- 
Regards,
 Viktor Mihajlovski

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] qemu: Don't refresh 'halted' state for domain stats

Posted by Jiri Denemark 6 years, 2 months ago

On Tue, Feb 06, 2018 at 16:30:51 +0100, Peter Krempa wrote:
> The halted state information is useless on most platforms and calling
> 'query-cpus' is very expensive. Don't report the info on platforms where
> it does not make sense.
> 
> Peter Krempa (3):
>   qemu: driver: Extract vcpu halted state directly
>   qemu: Remove unused 'cpuhalted' argument from qemuDomainHelperGetVcpus
>   qemu: domain: Store vcpu halted state as a tristate
> 
> Viktor Mihajlovski (1):
>   qemu: Limit refresh of CPU halted state to s390
> 
>  src/qemu/qemu_domain.c |  8 +++++++-
>  src/qemu/qemu_domain.h |  2 +-
>  src/qemu/qemu_driver.c | 36 +++++++++++++++---------------------
>  3 files changed, 23 insertions(+), 23 deletions(-)

ACK series

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list