util: bitmap: Various fixes and improvements

[libvirt] [PATCH 0/6] util: bitmap: Various fixes and improvements

Peter Krempa posted 6 patches 6 years, 2 months ago

Download series mbox

Failed in applying to current master (apply log)

src/conf/domain_conf.c |   3 +-
src/util/virbitmap.c   | 213 +++++++++++++++++++++++++++++++++++--------------
src/util/virbitmap.h   |   2 +-
src/util/virresctrl.c  |   3 +-
tests/virbitmaptest.c  |   6 +-
5 files changed, 157 insertions(+), 70 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/6] util: bitmap: Various fixes and improvements

Posted by Peter Krempa 6 years, 2 months ago

Peter Krempa (6):
  util: bitmap: Rename 'max_bit' to 'nbits'
  util: bitmap: Fix function formatting and spacing
  util: bitmap: Add comments for functions which don't have them
  util: bitmap: Fix value of 'map_alloc' when shrinking bitmap
  util: bitmap: Use VIR_SHRINK_N in virBitmapShrink
  util: bitmap: Note that shrinking the bitmap requires clearing of
    unused bits

 src/conf/domain_conf.c |   3 +-
 src/util/virbitmap.c   | 213 +++++++++++++++++++++++++++++++++++--------------
 src/util/virbitmap.h   |   2 +-
 src/util/virresctrl.c  |   3 +-
 tests/virbitmaptest.c  |   6 +-
 5 files changed, 157 insertions(+), 70 deletions(-)

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/6] util: bitmap: Various fixes and improvements

Posted by Martin Kletzander 6 years, 2 months ago

On Mon, Feb 05, 2018 at 02:17:41PM +0100, Peter Krempa wrote:
>Peter Krempa (6):
>  util: bitmap: Rename 'max_bit' to 'nbits'
>  util: bitmap: Fix function formatting and spacing
>  util: bitmap: Add comments for functions which don't have them
>  util: bitmap: Fix value of 'map_alloc' when shrinking bitmap
>  util: bitmap: Use VIR_SHRINK_N in virBitmapShrink
>  util: bitmap: Note that shrinking the bitmap requires clearing of
>    unused bits
>
> src/conf/domain_conf.c |   3 +-
> src/util/virbitmap.c   | 213 +++++++++++++++++++++++++++++++++++--------------
> src/util/virbitmap.h   |   2 +-
> src/util/virresctrl.c  |   3 +-
> tests/virbitmaptest.c  |   6 +-
> 5 files changed, 157 insertions(+), 70 deletions(-)
>
>-- 
>2.15.0
>

ACK series, thanks for the fixes.--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list