Fix --keep-relative for block commit after libvirtd restart (blockdev-add saga)

[libvirt] [PATCH 0/3] Fix --keep-relative for block commit after libvirtd restart (blockdev-add saga)

Peter Krempa posted 3 patches 6 years, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1513243782.git.pkrempa@redhat.com

src/conf/domain_conf.c      | 136 ++++++++++++++++++++++++++++++++++----------
src/conf/domain_conf.h      |  17 +++++-
src/conf/snapshot_conf.c    |  18 +++---
src/libvirt_private.syms    |   2 +
src/network/bridge_driver.c |   2 +-
src/qemu/qemu_domain.c      |   4 +-
src/util/virstoragefile.c   |  20 +++++++
src/util/virstoragefile.h   |   8 +++
tests/qemublocktest.c       |   4 +-
tests/virstoragetest.c      |   2 +-
10 files changed, 168 insertions(+), 45 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] Fix --keep-relative for block commit after libvirtd restart (blockdev-add saga)

Posted by Peter Krempa 6 years, 4 months ago

Relative paths were restored from the disks on libvirtd restart. Now
that we load the backing chain from XML we'll need to store them
somewhere.

Peter Krempa (3):
  conf: Add infrastructure for disk source private data XML
  util: storage: Add helpers to parse and format relPath into
    privateData
  qemu: domain: Parse and format relPath into disk source private data

 src/conf/domain_conf.c      | 136 ++++++++++++++++++++++++++++++++++----------
 src/conf/domain_conf.h      |  17 +++++-
 src/conf/snapshot_conf.c    |  18 +++---
 src/libvirt_private.syms    |   2 +
 src/network/bridge_driver.c |   2 +-
 src/qemu/qemu_domain.c      |   4 +-
 src/util/virstoragefile.c   |  20 +++++++
 src/util/virstoragefile.h   |   8 +++
 tests/qemublocktest.c       |   4 +-
 tests/virstoragetest.c      |   2 +-
 10 files changed, 168 insertions(+), 45 deletions(-)

-- 
2.15.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] Fix --keep-relative for block commit after libvirtd restart (blockdev-add saga)

Posted by Michal Privoznik 6 years, 4 months ago

On 12/14/2017 10:30 AM, Peter Krempa wrote:
> Relative paths were restored from the disks on libvirtd restart. Now
> that we load the backing chain from XML we'll need to store them
> somewhere.
> 
> Peter Krempa (3):
>   conf: Add infrastructure for disk source private data XML
>   util: storage: Add helpers to parse and format relPath into
>     privateData
>   qemu: domain: Parse and format relPath into disk source private data
> 
>  src/conf/domain_conf.c      | 136 ++++++++++++++++++++++++++++++++++----------
>  src/conf/domain_conf.h      |  17 +++++-
>  src/conf/snapshot_conf.c    |  18 +++---
>  src/libvirt_private.syms    |   2 +
>  src/network/bridge_driver.c |   2 +-
>  src/qemu/qemu_domain.c      |   4 +-
>  src/util/virstoragefile.c   |  20 +++++++
>  src/util/virstoragefile.h   |   8 +++
>  tests/qemublocktest.c       |   4 +-
>  tests/virstoragetest.c      |   2 +-
>  10 files changed, 168 insertions(+), 45 deletions(-)
> 

ACK series.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list