Patches for: https://bugzilla.redhat.com/show_bug.cgi?id=1513190

You can also get the patches from my github:

https://github.com/zippy2/libvirt-php/commits/libvirt_domain_new

Apart from usual case where I just push patches immediately, I'm gonna give
others chance to review since it's not trivial change set.

Michal Privoznik (7):
  Make installation_get_xml hurt my eyes less.
  Rework libvirt_domain_new a bit
  installation_get_xml: Don't override defaults of <on_reboot/> and
    friends
  util: Introduce VIR_FREE
  libvirt_domain_new: Resolve couple of memleaks
  installation_get_xml: Resolve couple of memleaks
  src: Use VIR_FREE instead of free

 src/libvirt-connection.c |  26 ++---
 src/libvirt-domain.c     | 278 +++++++++++++++++++++++++++--------------------
 src/libvirt-network.c    |  26 ++---
 src/libvirt-node.c       |   9 +-
 src/libvirt-nodedev.c    |  52 ++++-----
 src/libvirt-nwfilter.c   |   6 +-
 src/libvirt-php.c        | 234 ++++++++++++++++++++-------------------
 src/libvirt-php.h        |   2 +-
 src/libvirt-snapshot.c   |   4 +-
 src/libvirt-storage.c    |  20 ++--
 src/util.c               |   2 +-
 src/util.h               |   6 +
 src/vncfunc.c            |   5 +-
 13 files changed, 362 insertions(+), 308 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Dec 07, 2017 at 10:22:55AM +0100, Michal Privoznik wrote:
> Patches for: https://bugzilla.redhat.com/show_bug.cgi?id=1513190
>
> You can also get the patches from my github:
>
> https://github.com/zippy2/libvirt-php/commits/libvirt_domain_new
>
> Apart from usual case where I just push patches immediately, I'm gonna give
> others chance to review since it's not trivial change set.

Since you're doing some basic cleanup, I'd suggest adding a patch to remove
single line commentaries, especially some old/testing assignments, expressions,
etc.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list