[v1] Remove some repetitive code from qemuDomainNamespace* functions

[libvirt] [PATCH 0/6] Remove some repetitive code from qemuDomainNamespace* functions

Ján Tomko posted 6 patches 6 years, 4 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1511546041.git.jtomko@redhat.com

src/qemu/qemu_domain.c  | 394 ++++++++++++++++++------------------------------
src/qemu/qemu_domain.h  |  30 ++--
src/qemu/qemu_driver.c  |   2 +-
src/qemu/qemu_hotplug.c |  42 +++---
4 files changed, 176 insertions(+), 292 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/6] Remove some repetitive code from qemuDomainNamespace* functions

Posted by Ján Tomko 6 years, 4 months ago

Ján Tomko (6):
  qemuDomainNamespaceTeardownHostdev: rename path to paths
  Introduce qemuDomainNamespaceMknodPaths
  Introduce qemuDomainNamespaceMknodPath
  Introduce qemuDomainNamespaceUnlinkPaths
  Introduce qemuDomainNamespaceUnlinkPath
  Do not pass driver to qemuDomainNamespace{Setup,Teardown} functions

 src/qemu/qemu_domain.c  | 394 ++++++++++++++++++------------------------------
 src/qemu/qemu_domain.h  |  30 ++--
 src/qemu/qemu_driver.c  |   2 +-
 src/qemu/qemu_hotplug.c |  42 +++---
 4 files changed, 176 insertions(+), 292 deletions(-)

-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/6] Remove some repetitive code from qemuDomainNamespace* functions

Posted by Michal Privoznik 6 years, 4 months ago

On 11/24/2017 06:54 PM, Ján Tomko wrote:
> Ján Tomko (6):
>   qemuDomainNamespaceTeardownHostdev: rename path to paths
>   Introduce qemuDomainNamespaceMknodPaths
>   Introduce qemuDomainNamespaceMknodPath
>   Introduce qemuDomainNamespaceUnlinkPaths
>   Introduce qemuDomainNamespaceUnlinkPath
>   Do not pass driver to qemuDomainNamespace{Setup,Teardown} functions
> 
>  src/qemu/qemu_domain.c  | 394 ++++++++++++++++++------------------------------
>  src/qemu/qemu_domain.h  |  30 ++--
>  src/qemu/qemu_driver.c  |   2 +-
>  src/qemu/qemu_hotplug.c |  42 +++---
>  4 files changed, 176 insertions(+), 292 deletions(-)
> 

I wanted to review this, but upstream had diverged too much - I'm
getting a lot of conflicts when trying to apply these. Can you resend?

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list