qemu: Fix race condition between block jobs and the end of migration

[libvirt] [PATCH 0/3] qemu: Fix race condition between block jobs and the end of migration

Jiri Denemark posted 3 patches 6 years, 6 months ago

Download series mbox

Failed in applying to current master (apply log)

src/qemu/qemu_domain.c       |  1 +
src/qemu/qemu_domain.h       |  1 +
src/qemu/qemu_migration.c    | 75 +++++++++++++++++++++++++++++++++++++++++++-
src/qemu/qemu_monitor.c      | 18 +++++++++--
src/qemu/qemu_monitor.h      |  6 ++++
src/qemu/qemu_monitor_json.c | 29 +++++++++++++++++
src/qemu/qemu_monitor_json.h |  4 +++
7 files changed, 131 insertions(+), 3 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/3] qemu: Fix race condition between block jobs and the end of migration

Posted by Jiri Denemark 6 years, 6 months ago

When migrating both memory and storage, we need to make sure block jobs
are finished after the virtual CPUs get paused at the end of migration
but before QEMU completes the migration otherwise QEMU may die with

    _co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed

This is a libvirt side of the QEMU fix from Dr. David Alan Gilbert:

http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg04895.html

Applicable on top of my "Preparation for new QEMU migration states"
series I sent yesterday.

Jiri Denemark (3):
  qemu: Add support for migrate-continue QMP command
  qemu: Add pause-before-switchover migration capability
  qemu: Enabled pause-before-switchover migration capability

 src/qemu/qemu_domain.c       |  1 +
 src/qemu/qemu_domain.h       |  1 +
 src/qemu/qemu_migration.c    | 75 +++++++++++++++++++++++++++++++++++++++++++-
 src/qemu/qemu_monitor.c      | 18 +++++++++--
 src/qemu/qemu_monitor.h      |  6 ++++
 src/qemu/qemu_monitor_json.c | 29 +++++++++++++++++
 src/qemu/qemu_monitor_json.h |  4 +++
 7 files changed, 131 insertions(+), 3 deletions(-)

-- 
2.14.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] qemu: Fix race condition between block jobs and the end of migration

Posted by Ján Tomko 6 years, 6 months ago

On Fri, Oct 20, 2017 at 02:04:26PM +0200, Jiri Denemark wrote:
>When migrating both memory and storage, we need to make sure block jobs
>are finished after the virtual CPUs get paused at the end of migration
>but before QEMU completes the migration otherwise QEMU may die with
>
>    _co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed
>
>This is a libvirt side of the QEMU fix from Dr. David Alan Gilbert:
>
>http://lists.nongnu.org/archive/html/qemu-devel/2017-10/msg04895.html
>
>Applicable on top of my "Preparation for new QEMU migration states"
>series I sent yesterday.
>
>Jiri Denemark (3):
>  qemu: Add support for migrate-continue QMP command
>  qemu: Add pause-before-switchover migration capability
>  qemu: Enabled pause-before-switchover migration capability
>
> src/qemu/qemu_domain.c       |  1 +
> src/qemu/qemu_domain.h       |  1 +
> src/qemu/qemu_migration.c    | 75 +++++++++++++++++++++++++++++++++++++++++++-
> src/qemu/qemu_monitor.c      | 18 +++++++++--
> src/qemu/qemu_monitor.h      |  6 ++++
> src/qemu/qemu_monitor_json.c | 29 +++++++++++++++++
> src/qemu/qemu_monitor_json.h |  4 +++
> 7 files changed, 131 insertions(+), 3 deletions(-)
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list