qemu: Validate guest CPU features before starting a domain

[libvirt] [PATCH 0/4] qemu: Validate guest CPU features before starting a domain

Jiri Denemark posted 4 patches 6 years, 7 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1505398829.git.jdenemar@redhat.com

src/cpu/cpu.c            | 29 +++++++++++++++++++++++++++++
src/cpu/cpu.h            |  9 +++++++++
src/cpu/cpu_s390.c       | 29 +++++++++++++++++++++--------
src/cpu/cpu_x86.c        | 23 +++++++++++++++++++++++
src/libvirt_private.syms |  1 +
src/qemu/qemu_process.c  |  4 ++++
6 files changed, 87 insertions(+), 8 deletions(-)

Expand all Fold all

[libvirt] [PATCH 0/4] qemu: Validate guest CPU features before starting a domain

Posted by Jiri Denemark 6 years, 7 months ago

CPU features are usually checked by libvirt, but not if libvirt decides
it should not check the CPU at all, which happens with host-passthrough
CPUs, for example. Let's check all used CPU features are valid for all
CPU definitions.

https://bugzilla.redhat.com/show_bug.cgi?id=1460086

Jiri Denemark (4):
  cpu: Introduce virCPUValidateFeatures
  qemu: Validate guest CPU features before starting a domain
  cpu_s390: Implement virCPUValidateFeatures
  cpu_x86: Implement virCPUValidateFeatures

 src/cpu/cpu.c            | 29 +++++++++++++++++++++++++++++
 src/cpu/cpu.h            |  9 +++++++++
 src/cpu/cpu_s390.c       | 29 +++++++++++++++++++++--------
 src/cpu/cpu_x86.c        | 23 +++++++++++++++++++++++
 src/libvirt_private.syms |  1 +
 src/qemu/qemu_process.c  |  4 ++++
 6 files changed, 87 insertions(+), 8 deletions(-)

-- 
2.14.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/4] qemu: Validate guest CPU features before starting a domain

Posted by Ján Tomko 6 years, 7 months ago

On Thu, Sep 14, 2017 at 04:22:59PM +0200, Jiri Denemark wrote:
>CPU features are usually checked by libvirt, but not if libvirt decides
>it should not check the CPU at all, which happens with host-passthrough
>CPUs, for example. Let's check all used CPU features are valid for all
>CPU definitions.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1460086
>
>Jiri Denemark (4):
>  cpu: Introduce virCPUValidateFeatures
>  qemu: Validate guest CPU features before starting a domain
>  cpu_s390: Implement virCPUValidateFeatures
>  cpu_x86: Implement virCPUValidateFeatures
>
> src/cpu/cpu.c            | 29 +++++++++++++++++++++++++++++
> src/cpu/cpu.h            |  9 +++++++++
> src/cpu/cpu_s390.c       | 29 +++++++++++++++++++++--------
> src/cpu/cpu_x86.c        | 23 +++++++++++++++++++++++
> src/libvirt_private.syms |  1 +
> src/qemu/qemu_process.c  |  4 ++++
> 6 files changed, 87 insertions(+), 8 deletions(-)
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list