Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368753

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 tools/virsh.pod | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/tools/virsh.pod b/tools/virsh.pod
index 14a01e9ba..8ab93faf2 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -636,13 +636,15 @@ the I<--force> flag may be specified, requesting to disconnect any existing
 sessions, such as in a case of a broken connection.
 
 =item B<create> I<FILE> [I<--console>] [I<--paused>] [I<--autodestroy>]
-[I<--pass-fds N,M,...>]
+[I<--pass-fds N,M,...>] [I<--validate>]
 
-Create a domain from an XML <file>. An easy way to create the XML
-<file> is to use the B<dumpxml> command to obtain the definition of a
-pre-existing guest.  The domain will be paused if the I<--paused> option
-is used and supported by the driver; otherwise it will be running.
-If I<--console> is requested, attach to the console after creation.
+Create a domain from an XML <file>. Optionally, I<--validate> option can be
+passed to validate the format of the input XML file against an internal RNG
+schema (identical to using L<virt-xml-validate(1)> tool). An easy way to create
+the XML <file> is to use the B<dumpxml> command to obtain the definition of a
+pre-existing guest.  The domain will be paused if the I<--paused> option is used
+and supported by the driver; otherwise it will be running. If I<--console> is
+requested, attach to the console after creation.
 If I<--autodestroy> is requested, then the guest will be automatically
 destroyed when virsh closes its connection to libvirt, or otherwise
 exits.
@@ -663,10 +665,12 @@ B<Example>
  vi domain.xml (or make changes with your other text editor)
  virsh create domain.xml
 
-=item B<define> I<FILE>
+=item B<define> I<FILE> [I<--validate>]
 
-Define a domain from an XML <file>. The domain definition is registered
-but not started.  If domain is already running, the changes will take
+Define a domain from an XML <file>. Optionally, the format of the input XML
+file can be validated against an internal RNG schema with I<--validate>
+(identical to using L<virt-xml-validate(1)> tool). The domain definition is
+registered but not started.  If domain is already running, the changes will take
 effect on the next boot.
 
 =item B<desc> I<domain> [[I<--live>] [I<--config>] |
-- 
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Thu, Sep 07, 2017 at 03:48:14PM +0200, Erik Skultety wrote:
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1368753
>
>Signed-off-by: Erik Skultety <eskultet@redhat.com>
>---
> tools/virsh.pod | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
>
>diff --git a/tools/virsh.pod b/tools/virsh.pod
>index 14a01e9ba..8ab93faf2 100644
>--- a/tools/virsh.pod
>+++ b/tools/virsh.pod
>@@ -636,13 +636,15 @@ the I<--force> flag may be specified, requesting to disconnect any existing
> sessions, such as in a case of a broken connection.
>
> =item B<create> I<FILE> [I<--console>] [I<--paused>] [I<--autodestroy>]
>-[I<--pass-fds N,M,...>]
>+[I<--pass-fds N,M,...>] [I<--validate>]
>
>-Create a domain from an XML <file>. An easy way to create the XML
>-<file> is to use the B<dumpxml> command to obtain the definition of a
>-pre-existing guest.  The domain will be paused if the I<--paused> option
>-is used and supported by the driver; otherwise it will be running.
>-If I<--console> is requested, attach to the console after creation.
>+Create a domain from an XML <file>. Optionally, I<--validate> option can be
>+passed to validate the format of the input XML file against an internal RNG
>+schema (identical to using L<virt-xml-validate(1)> tool). An easy way to create
>+the XML <file> is to use the B<dumpxml> command to obtain the definition of a
>+pre-existing guest.  The domain will be paused if the I<--paused> option is used
>+and supported by the driver; otherwise it will be running. If I<--console> is
>+requested, attach to the console after creation.
> If I<--autodestroy> is requested, then the guest will be automatically
> destroyed when virsh closes its connection to libvirt, or otherwise
> exits.
>@@ -663,10 +665,12 @@ B<Example>
>  vi domain.xml (or make changes with your other text editor)
>  virsh create domain.xml
>
>-=item B<define> I<FILE>
>+=item B<define> I<FILE> [I<--validate>]
>
>-Define a domain from an XML <file>. The domain definition is registered
>-but not started.  If domain is already running, the changes will take
>+Define a domain from an XML <file>. Optionally, the format of the input XML
>+file can be validated against an internal RNG schema with I<--validate>
>+(identical to using L<virt-xml-validate(1)> tool). The domain definition is
>+registered but not started.  If domain is already running, the changes will take
> effect on the next boot.
>

I though we made this the default.  It looks like we did that only for
cmdEdit.  In that case,

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>


> =item B<desc> I<domain> [[I<--live>] [I<--config>] |
>--
>2.13.3
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list