Couple of trivial fixes/improvements

[libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements

Posted by Michal Privoznik 6 years, 7 months ago

*** BLURB HERE ***

Michal Privoznik (3):
  Shut up automake
  libvirt-php.c: Reorder includes
  examples: Initialize $ret in index.php

 configure.ac       | 4 ++++
 examples/index.php | 1 +
 src/libvirt-php.c  | 8 ++++----
 3 files changed, 9 insertions(+), 4 deletions(-)

-- 
2.13.5

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements

Posted by Martin Kletzander 6 years, 7 months ago

On Mon, Aug 28, 2017 at 04:45:45PM +0200, Michal Privoznik wrote:
>*** BLURB HERE ***
>
>Michal Privoznik (3):
>  Shut up automake
>  libvirt-php.c: Reorder includes

s/OCD/CDO/ ? =D

Seems sane, ACK series.

>  examples: Initialize $ret in index.php
>
> configure.ac       | 4 ++++
> examples/index.php | 1 +
> src/libvirt-php.c  | 8 ++++----
> 3 files changed, 9 insertions(+), 4 deletions(-)
>
>--
>2.13.5
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements

Posted by Michal Privoznik 6 years, 7 months ago

On 08/29/2017 09:55 AM, Martin Kletzander wrote:
> On Mon, Aug 28, 2017 at 04:45:45PM +0200, Michal Privoznik wrote:
>> *** BLURB HERE ***
>>
>> Michal Privoznik (3):
>>  Shut up automake
>>  libvirt-php.c: Reorder includes
> 
> s/OCD/CDO/ ? =D

:-)

> 
> Seems sane, ACK series.

Oh these are already pushed. Since there were no reviewers for -php I've
started to push patches and then merely send them to the list for others
to know. Should have said that in the cover letter, sorry.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements

Posted by Martin Kletzander 6 years, 7 months ago

On Tue, Aug 29, 2017 at 09:57:55AM +0200, Michal Privoznik wrote:
>On 08/29/2017 09:55 AM, Martin Kletzander wrote:
>> On Mon, Aug 28, 2017 at 04:45:45PM +0200, Michal Privoznik wrote:
>>> *** BLURB HERE ***
>>>
>>> Michal Privoznik (3):
>>>  Shut up automake
>>>  libvirt-php.c: Reorder includes
>>
>> s/OCD/CDO/ ? =D
>
>:-)
>
>>
>> Seems sane, ACK series.
>
>
>Oh these are already pushed. Since there were no reviewers for -php I've
>started to push patches and then merely send them to the list for others
>to know. Should have said that in the cover letter, sorry.
>

No need to, you can push it under the rule of well nobody actually reads
them.  In that case maybe there is no need to send them to the ML?  But
I'd leave that up to you.  I just didn't see anyone in similar position
doing that before ;)

>Michal
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list