[libvirt] [PATCH 1/7] virConnect: Update comment for @privateData

Michal Privoznik posted 7 patches 8 years, 6 months ago
[libvirt] [PATCH 1/7] virConnect: Update comment for @privateData
Posted by Michal Privoznik 8 years, 6 months ago
This member allows us to store a pointer to some private data.
However, the comment says it's used in both domain driver and
network driver. Well, it is not. It's just one pointer and domain
driver uses it directly. Network driver has a global driver
variable. Update the comment to not confuse others.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/datatypes.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/datatypes.h b/src/datatypes.h
index 288e057cc..8a0399cd0 100644
--- a/src/datatypes.h
+++ b/src/datatypes.h
@@ -472,8 +472,8 @@ struct _virConnect {
     virSecretDriverPtr secretDriver;
     virNWFilterDriverPtr nwfilterDriver;
 
-    /* Private data pointer which can be used by driver and
-     * network driver as they wish.
+    /* Private data pointer which can be used by domain driver as
+     * it pleases.
      * NB: 'private' is a reserved word in C++.
      */
     void *            privateData;
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/7] virConnect: Update comment for @privateData
Posted by Martin Kletzander 8 years, 6 months ago
On Thu, Jul 27, 2017 at 01:47:21PM +0200, Michal Privoznik wrote:
>This member allows us to store a pointer to some private data.
>However, the comment says it's used in both domain driver and
>network driver. Well, it is not. It's just one pointer and domain
>driver uses it directly. Network driver has a global driver
>variable. Update the comment to not confuse others.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>---
> src/datatypes.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

ACK, trivial

>
>diff --git a/src/datatypes.h b/src/datatypes.h
>index 288e057cc..8a0399cd0 100644
>--- a/src/datatypes.h
>+++ b/src/datatypes.h
>@@ -472,8 +472,8 @@ struct _virConnect {
>     virSecretDriverPtr secretDriver;
>     virNWFilterDriverPtr nwfilterDriver;
>
>-    /* Private data pointer which can be used by driver and
>-     * network driver as they wish.
>+    /* Private data pointer which can be used by domain driver as
>+     * it pleases.
>      * NB: 'private' is a reserved word in C++.
>      */
>     void *            privateData;
>--
>2.13.0
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list