This function has grown to format more than just the address.
Delete the comment completely to avoid failing to update it
in the future.

Also, the indentation is now handled by the virBuffer APIs,
so the comment about indentation no longer makes sense.
---
 src/conf/domain_conf.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 73c4b55e9..6c958bcf6 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5349,9 +5349,6 @@ virDomainVirtioOptionsFormat(virBufferPtr buf,
 }
 
 
-/* Generate a string representation of a device address
- * @info address Device address to stringify
- */
 static int ATTRIBUTE_NONNULL(2)
 virDomainDeviceInfoFormat(virBufferPtr buf,
                           virDomainDeviceInfoPtr info,
@@ -5400,7 +5397,6 @@ virDomainDeviceInfoFormat(virBufferPtr buf,
         info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390)
         return 0;
 
-    /* We'll be in domain/devices/[device type]/ so 3 level indent */
     virBufferAsprintf(buf, "<address type='%s'",
                       virDomainDeviceAddressTypeToString(info->type));
 
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On 07/26/2017 09:29 AM, Ján Tomko wrote:
> This function has grown to format more than just the address.
> Delete the comment completely to avoid failing to update it
> in the future.
> 
> Also, the indentation is now handled by the virBuffer APIs,
> so the comment about indentation no longer makes sense.
> ---
>  src/conf/domain_conf.c | 4 ----
>  1 file changed, 4 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@redhat.com>

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list