qemu: refactor node name detection

[libvirt] [PATCH 11/24] tests: qemumontitorjson: temporarily disable node name detection tests

Posted by Peter Krempa 8 years, 6 months ago

To simplify the refactoring patches disable the tests. This will allow
to add test data later.
---
 tests/qemumonitorjsontest.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
index 268c15f4b..c3e86419d 100644
--- a/tests/qemumonitorjsontest.c
+++ b/tests/qemumonitorjsontest.c
@@ -2930,9 +2930,9 @@ mymain(void)
     } while (0)

     DO_TEST_BLOCK_NODE_DETECT("basic", "#block118");
-    DO_TEST_BLOCK_NODE_DETECT("same-backing", "#block170,#block574");
-    DO_TEST_BLOCK_NODE_DETECT("relative", "#block153,#block1177");
-    DO_TEST_BLOCK_NODE_DETECT("gluster", "#block1008");
+/*    DO_TEST_BLOCK_NODE_DETECT("same-backing", "#block170,#block574"); */
+/*    DO_TEST_BLOCK_NODE_DETECT("relative", "#block153,#block1177"); */
+/*    DO_TEST_BLOCK_NODE_DETECT("gluster", "#block1008"); */

 #undef DO_TEST_BLOCK_NODE_DETECT

-- 
2.13.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 11/24] tests: qemumontitorjson: temporarily disable node name detection tests

Posted by Eric Blake 8 years, 6 months ago

On 07/26/2017 05:00 AM, Peter Krempa wrote:
> To simplify the refactoring patches disable the tests. This will allow
> to add test data later.

s/to add/adding/ ("allow to VERB" is not idiomatic English; it's either
"allow WHO to VERB", or the shorter "allow VERBing")

> ---
>  tests/qemumonitorjsontest.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c
> index 268c15f4b..c3e86419d 100644
> --- a/tests/qemumonitorjsontest.c
> +++ b/tests/qemumonitorjsontest.c
> @@ -2930,9 +2930,9 @@ mymain(void)
>      } while (0)
> 
>      DO_TEST_BLOCK_NODE_DETECT("basic", "#block118");
> -    DO_TEST_BLOCK_NODE_DETECT("same-backing", "#block170,#block574");
> -    DO_TEST_BLOCK_NODE_DETECT("relative", "#block153,#block1177");
> -    DO_TEST_BLOCK_NODE_DETECT("gluster", "#block1008");
> +/*    DO_TEST_BLOCK_NODE_DETECT("same-backing", "#block170,#block574"); */
> +/*    DO_TEST_BLOCK_NODE_DETECT("relative", "#block153,#block1177"); */
> +/*    DO_TEST_BLOCK_NODE_DETECT("gluster", "#block1008"); */
> 
>  #undef DO_TEST_BLOCK_NODE_DETECT
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list