[v1] properly handle '=' in the VNC socket path

[libvirt] [PATCH 0/3] properly handle '=' in the VNC socket path

Pavel Hrdina posted 3 patches 6 years, 9 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1500660516.git.phrdina@redhat.com

There is a newer version of this series

src/qemu/qemu_capabilities.c                       |  4 ++
src/qemu/qemu_capabilities.h                       |  3 ++
src/qemu/qemu_command.c                            |  5 ++-
src/qemu/qemu_process.c                            | 51 ++++++++++++++++++++--
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  1 +
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  1 +
.../caps_2.6.0-gicv2.aarch64.xml                   |  1 +
.../caps_2.6.0-gicv3.aarch64.xml                   |  1 +
tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  1 +
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml    |  1 +
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml   |  1 +
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |  1 +
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |  1 +
tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml  |  1 +
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml    |  1 +
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |  1 +
...muxml2argv-graphics-vnc-socket-new-cmdline.args | 22 ++++++++++
...emuxml2argv-graphics-vnc-socket-new-cmdline.xml | 20 +++++++++
...argv-graphics-vnc-socket-path-not-supported.xml |  1 +
.../qemuxml2argvdata/qemuxml2argv-name-escape.args |  2 +-
tests/qemuxml2argvtest.c                           |  5 +++
22 files changed, 121 insertions(+), 5 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket-new-cmdline.args
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket-new-cmdline.xml
create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket-path-not-supported.xml

Expand all Fold all

[libvirt] [PATCH 0/3] properly handle '=' in the VNC socket path

Posted by Pavel Hrdina 6 years, 9 months ago

Pavel Hrdina (3):
  qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS
  qemu: properly handle '=' in the VNC socket path
  tests: add test case for VNC unix path with '='

 src/qemu/qemu_capabilities.c                       |  4 ++
 src/qemu/qemu_capabilities.h                       |  3 ++
 src/qemu/qemu_command.c                            |  5 ++-
 src/qemu/qemu_process.c                            | 51 ++++++++++++++++++++--
 tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml   |  1 +
 .../caps_2.6.0-gicv2.aarch64.xml                   |  1 +
 .../caps_2.6.0-gicv3.aarch64.xml                   |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml    |  1 +
 tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml    |  1 +
 tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml   |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml  |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml    |  1 +
 tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml   |  1 +
 ...muxml2argv-graphics-vnc-socket-new-cmdline.args | 22 ++++++++++
 ...emuxml2argv-graphics-vnc-socket-new-cmdline.xml | 20 +++++++++
 ...argv-graphics-vnc-socket-path-not-supported.xml |  1 +
 .../qemuxml2argvdata/qemuxml2argv-name-escape.args |  2 +-
 tests/qemuxml2argvtest.c                           |  5 +++
 22 files changed, 121 insertions(+), 5 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket-new-cmdline.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket-new-cmdline.xml
 create mode 120000 tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket-path-not-supported.xml

-- 
2.13.3

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] properly handle '=' in the VNC socket path

Posted by Ján Tomko 6 years, 8 months ago

On Fri, Jul 21, 2017 at 08:11:28PM +0200, Pavel Hrdina wrote:
>Pavel Hrdina (3):
>  qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS
>  qemu: properly handle '=' in the VNC socket path
>  tests: add test case for VNC unix path with '='
>

ACK series

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 0/3] properly handle '=' in the VNC socket path

Posted by Pavel Hrdina 6 years, 8 months ago

On Wed, Jul 26, 2017 at 03:41:13PM +0200, Ján Tomko wrote:
> On Fri, Jul 21, 2017 at 08:11:28PM +0200, Pavel Hrdina wrote:
> >Pavel Hrdina (3):
> >  qemu: capabilities: introduce QEMU_CAPS_VNC_MULTI_SERVERS
> >  qemu: properly handle '=' in the VNC socket path
> >  tests: add test case for VNC unix path with '='
> >
> 
> ACK series
> 
> Jan

Thanks, but I have to SNACK it.  We can safely use the old syntax if
QEMU_CAPS_VNC_MULTI_SERVERS is not available.  I'll send a v2.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list