[libvirt] [PATCH v2 0/6] Convert port to unsigned integer

Peter Krempa posted 6 patches 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1500553294.git.pkrempa@redhat.com
src/conf/domain_conf.c                | 133 +++++++++++++++++++---------------
src/libvirt_private.syms              |   1 +
src/libxl/libxl_conf.c                |   2 +-
src/qemu/qemu_block.c                 |   7 +-
src/qemu/qemu_command.c               |  30 ++------
src/qemu/qemu_parse_command.c         |  13 ++--
src/storage/storage_backend_gluster.c |  17 +----
src/storage/storage_driver.c          |   7 +-
src/util/virstoragefile.c             |  68 +++++++----------
src/util/virstoragefile.h             |   4 +-
src/util/virstring.c                  |  37 ++++++++++
src/util/virstring.h                  |   4 +
src/util/viruri.h                     |   2 +-
src/xenconfig/xen_xl.c                |   2 +-
tests/virstoragetest.c                |  14 ++--
15 files changed, 182 insertions(+), 159 deletions(-)
[libvirt] [PATCH v2 0/6] Convert port to unsigned integer
Posted by Peter Krempa 6 years, 9 months ago
Since Michal did not want to finis this I did. I also found a few bugs in
my previous patches which are addressed here.

Peter Krempa (6):
  qemu: command: Rename and move qemuNetworkDriveGetPort
  util: uri: Convert port number to unsigned integer
  qemu: command: Remove condition to use default sheepdog port
  util: storage: fill in default ports when parsing backing chain
  conf: domain: Split up virDomainStorageHostParse and rename it
  virStorageNetHostDef: Turn @port into integer

 src/conf/domain_conf.c                | 133 +++++++++++++++++++---------------
 src/libvirt_private.syms              |   1 +
 src/libxl/libxl_conf.c                |   2 +-
 src/qemu/qemu_block.c                 |   7 +-
 src/qemu/qemu_command.c               |  30 ++------
 src/qemu/qemu_parse_command.c         |  13 ++--
 src/storage/storage_backend_gluster.c |  17 +----
 src/storage/storage_driver.c          |   7 +-
 src/util/virstoragefile.c             |  68 +++++++----------
 src/util/virstoragefile.h             |   4 +-
 src/util/virstring.c                  |  37 ++++++++++
 src/util/virstring.h                  |   4 +
 src/util/viruri.h                     |   2 +-
 src/xenconfig/xen_xl.c                |   2 +-
 tests/virstoragetest.c                |  14 ++--
 15 files changed, 182 insertions(+), 159 deletions(-)

-- 
2.13.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/6] Convert port to unsigned integer
Posted by Ján Tomko 6 years, 9 months ago
On Thu, Jul 20, 2017 at 02:29:57PM +0200, Peter Krempa wrote:
>Since Michal did not want to finis this I did. I also found a few bugs in
>my previous patches which are addressed here.
>

Thank you for taking this up, even though you did not finish the word
'finish'.

>Peter Krempa (6):
>  qemu: command: Rename and move qemuNetworkDriveGetPort
>  util: uri: Convert port number to unsigned integer
>  qemu: command: Remove condition to use default sheepdog port
>  util: storage: fill in default ports when parsing backing chain
>  conf: domain: Split up virDomainStorageHostParse and rename it
>  virStorageNetHostDef: Turn @port into integer
>
> src/conf/domain_conf.c                | 133 +++++++++++++++++++---------------
> src/libvirt_private.syms              |   1 +
> src/libxl/libxl_conf.c                |   2 +-
> src/qemu/qemu_block.c                 |   7 +-
> src/qemu/qemu_command.c               |  30 ++------
> src/qemu/qemu_parse_command.c         |  13 ++--
> src/storage/storage_backend_gluster.c |  17 +----
> src/storage/storage_driver.c          |   7 +-
> src/util/virstoragefile.c             |  68 +++++++----------
> src/util/virstoragefile.h             |   4 +-
> src/util/virstring.c                  |  37 ++++++++++
> src/util/virstring.h                  |   4 +
> src/util/viruri.h                     |   2 +-
> src/xenconfig/xen_xl.c                |   2 +-
> tests/virstoragetest.c                |  14 ++--
> 15 files changed, 182 insertions(+), 159 deletions(-)

ACK series.

Jan
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list