[libvirt] [PATCH 4/5] qemu: migration: Use virStorageSourceIsEmpty in qemuMigrateDisk

Peter Krempa posted 5 patches 8 years, 10 months ago
[libvirt] [PATCH 4/5] qemu: migration: Use virStorageSourceIsEmpty in qemuMigrateDisk
Posted by Peter Krempa 8 years, 10 months ago
Use the proper check whether a disk is empty.
---
 src/qemu/qemu_migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 5bd45137c..46f82ab33 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -415,7 +415,7 @@ qemuMigrateDisk(virDomainDiskDef const *disk,
     /* Default is to migrate only non-shared non-readonly disks
      * with source */
     return !disk->src->shared && !disk->src->readonly &&
-           virDomainDiskGetSource(disk);
+           !virStorageSourceIsEmpty(disk->src);
 }


-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 4/5] qemu: migration: Use virStorageSourceIsEmpty in qemuMigrateDisk
Posted by John Ferlan 8 years, 10 months ago

On 04/07/2017 11:50 AM, Peter Krempa wrote:
> Use the proper check whether a disk is empty.
> ---
>  src/qemu/qemu_migration.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

ACK

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list