[v2] Rework sysfs handling

[libvirt] [PATCH v2 02/12] util: Fix virDirRead() description

Posted by Martin Kletzander 8 years, 10 months ago

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 src/util/virfile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/virfile.c b/src/util/virfile.c
index a91c2c349501..c0f448d3437d 100644
--- a/src/util/virfile.c
+++ b/src/util/virfile.c
@@ -2861,11 +2861,11 @@ virDirOpenQuiet(DIR **dirp, const char *name)
 /**
  * virDirRead:
  * @dirp: directory to read
- * @end: output one entry
+ * @ent: output one entry
  * @name: if non-NULL, the name related to @dirp for use in error reporting
  *
  * Wrapper around readdir. Typical usage:
- *   struct dirent ent;
+ *   struct dirent *ent;
  *   int rc;
  *   DIR *dir;
  *   if (virDirOpen(&dir, name) < 0)
-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH v2 02/12] util: Fix virDirRead() description

Posted by Erik Skultety 8 years, 10 months ago

On Wed, Apr 05, 2017 at 04:36:25PM +0200, Martin Kletzander wrote:
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
>  src/util/virfile.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index a91c2c349501..c0f448d3437d 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -2861,11 +2861,11 @@ virDirOpenQuiet(DIR **dirp, const char *name)
>  /**
>   * virDirRead:
>   * @dirp: directory to read
> - * @end: output one entry
> + * @ent: output one entry
>   * @name: if non-NULL, the name related to @dirp for use in error reporting
>   *
>   * Wrapper around readdir. Typical usage:
> - *   struct dirent ent;
> + *   struct dirent *ent;
>   *   int rc;
>   *   DIR *dir;
>   *   if (virDirOpen(&dir, name) < 0)
> --
> 2.12.2
>

ACK (could have gone straight in as trivial :)).

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list