Naming, style and other fixes suggested by Andrea in his review. The changes
were too invasive so I'll rather repost it.

Peter Krempa (5):
  storage: util: Pass pool type to
    virStorageBackendFindGlusterPoolSources
  storage: util: Split out the gluster volume extraction code into new
    function
  test: Introduce testing of virStorageUtilGlusterExtractPoolSources
  storage: Fix XPath for looking up gluster volume name
  storage: gluster: Use volume name as "<name>" field in the XML

 src/storage/storage_backend_fs.c                   |   2 +-
 src/storage/storage_backend_gluster.c              |   2 +-
 src/storage/storage_util.c                         | 114 +++++++++++++--------
 src/storage/storage_util.h                         |   6 +-
 tests/Makefile.am                                  |  16 ++-
 .../gluster-parse-basic-native.xml                 |   7 ++
 .../gluster-parse-basic-netfs.xml                  |   7 ++
 .../virstorageutildata/gluster-parse-basic-src.xml |  47 +++++++++
 .../gluster-parse-multivol-native.xml              |  17 +++
 .../gluster-parse-multivol-netfs.xml               |  17 +++
 .../gluster-parse-multivol-src.xml                 |  32 ++++++
 tests/virstorageutiltest.c                         | 114 +++++++++++++++++++++
 12 files changed, 336 insertions(+), 45 deletions(-)
 create mode 100644 tests/virstorageutildata/gluster-parse-basic-native.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-basic-netfs.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-basic-src.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-multivol-native.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-multivol-netfs.xml
 create mode 100644 tests/virstorageutildata/gluster-parse-multivol-src.xml
 create mode 100644 tests/virstorageutiltest.c

-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, 2017-04-04 at 14:20 +0200, Peter Krempa wrote:
> Naming, style and other fixes suggested by Andrea in his review. The changes
> were too invasive so I'll rather repost it.

ACK series if you take care of the comments to patch 3/5.
Another respin should not be necessary.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Tue, Apr 04, 2017 at 16:09:11 +0200, Andrea Bolognani wrote:
> On Tue, 2017-04-04 at 14:20 +0200, Peter Krempa wrote:
> > Naming, style and other fixes suggested by Andrea in his review. The changes
> > were too invasive so I'll rather repost it.
> 
> ACK series if you take care of the comments to patch 3/5.
> Another respin should not be necessary.

Thanks, I've fixed those issues and pushed this series.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list