[libvirt] [PATCH 0/4] Start refactoring migration cookies

Jiri Denemark posted 4 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1490369794.git.jdenemar@redhat.com
po/POTFILES.in                   |    1 +
src/Makefile.am                  |    1 +
src/qemu/qemu_migration.c        | 1425 +-------------------------------------
src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++
src/qemu/qemu_migration_cookie.h |  153 ++++
5 files changed, 1512 insertions(+), 1416 deletions(-)
create mode 100644 src/qemu/qemu_migration_cookie.c
create mode 100644 src/qemu/qemu_migration_cookie.h
[libvirt] [PATCH 0/4] Start refactoring migration cookies
Posted by Jiri Denemark 7 years, 1 month ago
This series is a first step in refactoring migration cookies. The rest
will take some time until it's done, but I figured the part which moves
the code is very fragile and I don't really want to keep rebasing it
until the refactoring is finished.

Jiri Denemark (4):
  qemu: Move migration cookies to a separate file
  qemu: Fix formatting in qemu_migration_cookie.c
  qemu: Typedef migration cookie enums
  qemu: Free persistent def inside qemuMigrationCookieFree

 po/POTFILES.in                   |    1 +
 src/Makefile.am                  |    1 +
 src/qemu/qemu_migration.c        | 1425 +-------------------------------------
 src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++
 src/qemu/qemu_migration_cookie.h |  153 ++++
 5 files changed, 1512 insertions(+), 1416 deletions(-)
 create mode 100644 src/qemu/qemu_migration_cookie.c
 create mode 100644 src/qemu/qemu_migration_cookie.h

-- 
2.12.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Start refactoring migration cookies
Posted by John Ferlan 7 years ago

On 03/24/2017 11:40 AM, Jiri Denemark wrote:
> This series is a first step in refactoring migration cookies. The rest
> will take some time until it's done, but I figured the part which moves
> the code is very fragile and I don't really want to keep rebasing it
> until the refactoring is finished.
> 
> Jiri Denemark (4):
>   qemu: Move migration cookies to a separate file
>   qemu: Fix formatting in qemu_migration_cookie.c
>   qemu: Typedef migration cookie enums
>   qemu: Free persistent def inside qemuMigrationCookieFree
> 
>  po/POTFILES.in                   |    1 +
>  src/Makefile.am                  |    1 +
>  src/qemu/qemu_migration.c        | 1425 +-------------------------------------
>  src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++
>  src/qemu/qemu_migration_cookie.h |  153 ++++
>  5 files changed, 1512 insertions(+), 1416 deletions(-)
>  create mode 100644 src/qemu/qemu_migration_cookie.c
>  create mode 100644 src/qemu/qemu_migration_cookie.h
> 

I'm sure you already realize you had a conflict with the TLS series -
only need to be sure to keep the QEMU_MIGRATION_TLS_ALIAS_BASE

FWIW: while not required, the end of the new .h file should have

#endif /* __QEMU_MIGRATION_COOKIE_H__ */



ACK series,

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/4] Start refactoring migration cookies
Posted by Jiri Denemark 7 years ago
On Mon, Mar 27, 2017 at 14:30:49 -0400, John Ferlan wrote:
> 
> 
> On 03/24/2017 11:40 AM, Jiri Denemark wrote:
> > This series is a first step in refactoring migration cookies. The rest
> > will take some time until it's done, but I figured the part which moves
> > the code is very fragile and I don't really want to keep rebasing it
> > until the refactoring is finished.
> > 
> > Jiri Denemark (4):
> >   qemu: Move migration cookies to a separate file
> >   qemu: Fix formatting in qemu_migration_cookie.c
> >   qemu: Typedef migration cookie enums
> >   qemu: Free persistent def inside qemuMigrationCookieFree
> > 
> >  po/POTFILES.in                   |    1 +
> >  src/Makefile.am                  |    1 +
> >  src/qemu/qemu_migration.c        | 1425 +-------------------------------------
> >  src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++
> >  src/qemu/qemu_migration_cookie.h |  153 ++++
> >  5 files changed, 1512 insertions(+), 1416 deletions(-)
> >  create mode 100644 src/qemu/qemu_migration_cookie.c
> >  create mode 100644 src/qemu/qemu_migration_cookie.h
> > 
> 
> I'm sure you already realize you had a conflict with the TLS series -
> only need to be sure to keep the QEMU_MIGRATION_TLS_ALIAS_BASE

Yeah, this is the main reason why I wanted to push this patch before
starting to work on refactoring the code.

> FWIW: while not required, the end of the new .h file should have
> 
> #endif /* __QEMU_MIGRATION_COOKIE_H__ */

Added and pushed. Thanks.

Jirka

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list