Patches 1 and 2 are new in the series and add an option to override the check so
that users can use the feature despite being unsafe.

See patch 3/3 for clarification of the motiovation to do this.

Peter Krempa (3):
  virerror: Introduce VIR_ERR_OPERATION_UNSAFE
  snapshot: Introduce flag VIR_DOMAIN_SNAPSHOT_CREATE_UNSAFE
  qemu: snapshot: Forbid internal snapshots with pflash firmware

 include/libvirt/libvirt-domain-snapshot.h |  3 +++
 include/libvirt/virterror.h               |  1 +
 src/qemu/qemu_driver.c                    | 18 +++++++++++++++++-
 src/util/virerror.c                       |  5 +++++
 tools/virsh-snapshot.c                    |  6 ++++++
 tools/virsh.pod                           |  6 +++++-
 6 files changed, 37 insertions(+), 2 deletions(-)

-- 
2.12.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

On Fri, Mar 24, 2017 at 14:05:39 +0100, Peter Krempa wrote:
> Patches 1 and 2 are new in the series and add an option to override the check so
> that users can use the feature despite being unsafe.
> 
> See patch 3/3 for clarification of the motiovation to do this.
> 
> Peter Krempa (3):
>   virerror: Introduce VIR_ERR_OPERATION_UNSAFE
>   snapshot: Introduce flag VIR_DOMAIN_SNAPSHOT_CREATE_UNSAFE
>   qemu: snapshot: Forbid internal snapshots with pflash firmware

Self NACK series. Turns out that our HMP error detection for 'savevm'
sucks. Snapshots with PFLASH are not supported at all, but libvirt
thinks they are. V2 is the way to go with mentioning that actually it's
a libvirt bug.
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list