[libvirt] [PATCH 0/3] log|lock daemon: Don't spam logs with IO error messages after client disconnects

Peter Krempa posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1489765683.git.pkrempa@redhat.com
src/locking/lock_daemon.c    |  3 +++
src/logging/log_daemon.c     |  3 +++
src/rpc/virnetserverclient.c | 13 +++++++++++++
src/rpc/virnetserverclient.h |  2 ++
src/rpc/virnetsocket.c       | 33 +++++++++++++++++++++++++++------
src/rpc/virnetsocket.h       |  2 ++
6 files changed, 50 insertions(+), 6 deletions(-)
[libvirt] [PATCH 0/3] log|lock daemon: Don't spam logs with IO error messages after client disconnects
Posted by Peter Krempa 7 years, 1 month ago
See patch 3 for explanation

Peter Krempa (3):
  rpc: socket: Add possibility to suppress errors on read hangup
  rpc: serverclient: Add option to suppress errors on EOF
  (log|lock)daemon: Don't spam logs with IO error messages after client
    disconnects

 src/locking/lock_daemon.c    |  3 +++
 src/logging/log_daemon.c     |  3 +++
 src/rpc/virnetserverclient.c | 13 +++++++++++++
 src/rpc/virnetserverclient.h |  2 ++
 src/rpc/virnetsocket.c       | 33 +++++++++++++++++++++++++++------
 src/rpc/virnetsocket.h       |  2 ++
 6 files changed, 50 insertions(+), 6 deletions(-)

-- 
2.12.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] log|lock daemon: Don't spam logs with IO error messages after client disconnects
Posted by Daniel P. Berrange 7 years, 1 month ago
On Fri, Mar 17, 2017 at 04:48:48PM +0100, Peter Krempa wrote:
> See patch 3 for explanation
> 
> Peter Krempa (3):
>   rpc: socket: Add possibility to suppress errors on read hangup
>   rpc: serverclient: Add option to suppress errors on EOF
>   (log|lock)daemon: Don't spam logs with IO error messages after client
>     disconnects

ACK, if you add  'ret = -2' in the first patch where mentioned


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] log|lock daemon: Don't spam logs with IO error messages after client disconnects
Posted by Peter Krempa 7 years, 1 month ago
On Fri, Mar 17, 2017 at 16:15:03 +0000, Daniel Berrange wrote:
> On Fri, Mar 17, 2017 at 04:48:48PM +0100, Peter Krempa wrote:
> > See patch 3 for explanation
> > 
> > Peter Krempa (3):
> >   rpc: socket: Add possibility to suppress errors on read hangup
> >   rpc: serverclient: Add option to suppress errors on EOF
> >   (log|lock)daemon: Don't spam logs with IO error messages after client
> >     disconnects
> 
> ACK, if you add  'ret = -2' in the first patch where mentioned

Thanks, I've tweaked it and pushed.

Peter
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list