qemu: Big namespace cleanup

[libvirt] [PATCH 07/11] qemuDomainNamespaceSetupDisk: Drop useless @src variable

Posted by Michal Privoznik 9 years ago

Since its introduction in 81df21507bef9 this variable was never
used.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_domain.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 067b7a42f..8ec9601d2 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -7899,7 +7899,6 @@ qemuDomainNamespaceSetupDisk(virQEMUDriverPtr driver,
                              virDomainDiskDefPtr disk)
 {
     virStorageSourcePtr next;
-    const char *src = NULL;
     struct stat sb;
     int ret = -1;
 
@@ -7914,14 +7913,14 @@ qemuDomainNamespaceSetupDisk(virQEMUDriverPtr driver,
 
         if (stat(next->path, &sb) < 0) {
             virReportSystemError(errno,
-                                 _("Unable to access %s"), src);
+                                 _("Unable to access %s"), next->path);
             goto cleanup;
         }
 
         if (!S_ISBLK(sb.st_mode)) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("Disk source %s must be a block device"),
-                           src);
+                           next->path);
             goto cleanup;
         }
 
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 07/11] qemuDomainNamespaceSetupDisk: Drop useless @src variable

Posted by Peter Krempa 9 years ago

On Wed, Feb 08, 2017 at 11:37:10 +0100, Michal Privoznik wrote:
> Since its introduction in 81df21507bef9 this variable was never
> used.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_domain.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

ACK
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list