[libvirt] [PATCH 1/5] tests: Trace re-executing processes with valgrind

Michal Privoznik posted 5 patches 9 years ago
[libvirt] [PATCH 1/5] tests: Trace re-executing processes with valgrind
Posted by Michal Privoznik 9 years ago
A lot of our tests re-execute themeselves after loading their
mock library. This, however, makes valgrind sad because currently
we do not tell it to trace the process after exec().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index e923178f2..521728a3d 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -470,7 +470,8 @@ TESTS_ENVIRONMENT =				\
   $(VG)
 
 
-VALGRIND = valgrind --quiet --leak-check=full \
+VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \
+	--trace-children-skip="*/tools/virsh","*/tests/commandhelper" \
 	--suppressions=$(srcdir)/.valgrind.supp
 valgrind:
 	$(MAKE) check VG="libtool --mode=execute $(VALGRIND)"
-- 
2.11.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 1/5] tests: Trace re-executing processes with valgrind
Posted by John Ferlan 8 years, 12 months ago

On 02/06/2017 03:21 AM, Michal Privoznik wrote:
> A lot of our tests re-execute themeselves after loading their
> mock library. This, however, makes valgrind sad because currently
> we do not tell it to trace the process after exec().
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tests/Makefile.am | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

ACK (seems reasonable)

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list