docs: schemas: Decouple the virtio options from each other

[libvirt] [PATCH] docs: schemas: Decouple the virtio options from each other

Erik Skultety posted 1 patch 5 years, 3 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cad5088ddf2133ecfe428049d620e5b4d1485ed6.1546595023.git.eskultet@redhat.com

docs/schemas/domaincommon.rng | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[libvirt] [PATCH] docs: schemas: Decouple the virtio options from each other

Posted by Erik Skultety 5 years, 3 months ago

Currently, all of the VirtioOptions are under a single <optional>
element, however, neither our parser/formatter or QEMU driver requires
the presence of all the options if only a single one from the set has
been specified, so fix it and silence the schema validator.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 docs/schemas/domaincommon.rng | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 6518aff73a..aa50eac424 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -5498,6 +5498,8 @@
       <attribute name="iommu">
         <ref name="virOnOff"/>
       </attribute>
+    </optional>
+    <optional>
       <attribute name="ats">
         <ref name="virOnOff"/>
       </attribute>
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: schemas: Decouple the virtio options from each other

Posted by Ján Tomko 5 years, 3 months ago

On Fri, Jan 04, 2019 at 10:43:48AM +0100, Erik Skultety wrote:
>Currently, all of the VirtioOptions are under a single <optional>
>element, however, neither our parser/formatter or QEMU driver requires
>the presence of all the options if only a single one from the set has
>been specified, so fix it and silence the schema validator.
>
>Signed-off-by: Erik Skultety <eskultet@redhat.com>
>---
> docs/schemas/domaincommon.rng | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list