spec: Disable gluster on i686 on RHEL-8

[libvirt] [PATCH] spec: Disable gluster on i686 on RHEL-8

Posted by Jiri Denemark 4 years, 5 months ago

Gluster 6.0 is not built on i686 for RHEL-8, which prevents libvirt from
building. Let's just disable gluster there as all we need are client
libraries anyway.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 libvirt.spec.in | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index a6219da604..c7fac104d9 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -65,7 +65,15 @@
 %else
     %define with_storage_sheepdog 0
 %endif
+
 %define with_storage_gluster 0%{!?_without_storage_gluster:1}
+%ifnarch %{qemu_kvm_arches}
+    # gluster is only built where qemu driver is enabled on RHEL 8
+    %if 0%{?rhel} >= 8
+        %define with_storage_gluster 0
+    %endif
+%endif
+
 %define with_numactl          0%{!?_without_numactl:1}
 
 # F25+ has zfs-fuse
-- 
2.24.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] spec: Disable gluster on i686 on RHEL-8

Posted by Fabiano Fidêncio 4 years, 5 months ago

On Fri, Nov 29, 2019 at 3:02 PM Jiri Denemark <jdenemar@redhat.com> wrote:
>
> Gluster 6.0 is not built on i686 for RHEL-8, which prevents libvirt from
> building. Let's just disable gluster there as all we need are client
> libraries anyway.
>
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  libvirt.spec.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index a6219da604..c7fac104d9 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -65,7 +65,15 @@
>  %else
>      %define with_storage_sheepdog 0
>  %endif
> +
>  %define with_storage_gluster 0%{!?_without_storage_gluster:1}
> +%ifnarch %{qemu_kvm_arches}
> +    # gluster is only built where qemu driver is enabled on RHEL 8
> +    %if 0%{?rhel} >= 8
> +        %define with_storage_gluster 0
> +    %endif
> +%endif
> +
>  %define with_numactl          0%{!?_without_numactl:1}
>
>  # F25+ has zfs-fuse
> --
> 2.24.0
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>


--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list