[libvirt PATCH] docs: index: Add a quick link to Submitting patches

Erik Skultety posted 1 patch 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/c6d198bb37bc6f3f6bd461f1aac4713c3efd2ac3.1688459133.git.eskultet@redhat.com
docs/index.rst | 3 +++
1 file changed, 3 insertions(+)
[libvirt PATCH] docs: index: Add a quick link to Submitting patches
Posted by Erik Skultety 10 months ago
We still get MRs in Gitlab from individual contributors on a regular
basis which in some ways just makes maintainer's or reviewer's life
just a bit more complicated. This ultimately means our guidelines are
probably not visible enough on the main page
(or some people wouldn't read them anyway). While this patch can't make
the problem go away, it can at least attempt to mitigate it by creating
a quick link to the 'hacking' page, skipping a lot of TL;DR contents
in contributing.rst which we link from the main page.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

Feel free to reject this patch if you think it provides absolutely no value
towards mitigating the issue at hand.

 docs/index.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/index.rst b/docs/index.rst
index d55c4bb94d..eaadffaa9b 100644
--- a/docs/index.rst
+++ b/docs/index.rst
@@ -30,6 +30,9 @@ Quick Links
 
 `New contributors <contribute.html>`__
   Get involved in the libvirt community & student outreach programs
+`Submitting patches <hacking.html>`__
+  Already a regular open source contributor and have git set up? Have a quick
+  look at how to propose your changes to libvirt correctly
 `Security vulnerabilities <securityprocess.html>`__
   View security notices and report vulnerabilities to the libvirt security
   response team
-- 
2.41.0
Re: [libvirt PATCH] docs: index: Add a quick link to Submitting patches
Posted by Kristina Hanicova 9 months, 3 weeks ago
On Tue, Jul 4, 2023 at 10:26 AM Erik Skultety <eskultet@redhat.com> wrote:

> We still get MRs in Gitlab from individual contributors on a regular
> basis which in some ways just makes maintainer's or reviewer's life
> just a bit more complicated. This ultimately means our guidelines are
> probably not visible enough on the main page
> (or some people wouldn't read them anyway). While this patch can't make
> the problem go away, it can at least attempt to mitigate it by creating
> a quick link to the 'hacking' page, skipping a lot of TL;DR contents
> in contributing.rst which we link from the main page.
>
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>
> Feel free to reject this patch if you think it provides absolutely no value
> towards mitigating the issue at hand.
>
>  docs/index.rst | 3 +++
>  1 file changed, 3 insertions(+)
>

Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
Kristina