qemuxmlconftest: Add example for "sgio='filtered'" disk option

[PATCH] qemuxmlconftest: Add example for "sgio='filtered'" disk option

Peter Krempa via Devel posted 1 patch 1 week, 3 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/c3382557560a6252b6082ee40b484659d2e2c3a9.1760534895.git.pkrempa@redhat.com

.../qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml | 2 +-
tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml             | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] qemuxmlconftest: Add example for "sgio='filtered'" disk option

Posted by Peter Krempa via Devel 1 week, 3 days ago

From: Peter Krempa <pkrempa@redhat.com>

The test suite validates only the error with the "sgio='unfiltered'"
setting which isn't supported by the qemu driver. Validate also the
'filtered' used explicitly (the default behaviour if unspecified is the
same as 'filtered').

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 .../qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml | 2 +-
 tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml b/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml
index 6c0d3b41e8..8037cd8160 100644
--- a/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml
@@ -23,7 +23,7 @@
       <target dev='hda' bus='scsi'/>
       <address type='drive' controller='0' bus='0' target='0' unit='0'/>
     </disk>
-    <disk type='block' device='lun'>
+    <disk type='block' device='lun' sgio='filtered'>
       <driver name='qemu' type='raw'/>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdb' bus='scsi'/>
diff --git a/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml b/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml
index 2a3878e23d..6a055a5649 100644
--- a/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml
+++ b/tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml
@@ -19,7 +19,7 @@
       <target dev='hda' bus='scsi'/>
       <address type='drive' controller='0' bus='0' target='0' unit='0'/>
     </disk>
-    <disk type='block' device='lun'>
+    <disk type='block' device='lun' sgio='filtered'>
       <source dev='/dev/HostVG/QEMUGuest2'/>
       <target dev='hdb' bus='scsi'/>
       <address type='drive' controller='0' bus='0' target='1' unit='1'/>
-- 
2.51.0

Re: [PATCH] qemuxmlconftest: Add example for "sgio='filtered'" disk option

Posted by Michal Prívozník via Devel 1 week, 3 days ago

On 10/15/25 15:28, Peter Krempa via Devel wrote:
> From: Peter Krempa <pkrempa@redhat.com>
> 
> The test suite validates only the error with the "sgio='unfiltered'"
> setting which isn't supported by the qemu driver. Validate also the
> 'filtered' used explicitly (the default behaviour if unspecified is the
> same as 'filtered').
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  .../qemuxmlconfdata/disk-scsi-lun-passthrough.x86_64-latest.xml | 2 +-
>  tests/qemuxmlconfdata/disk-scsi-lun-passthrough.xml             | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal