docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

[PATCH] docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

Peter Krempa posted 1 patch 4 years, 3 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/c2f0b6214559fe5d7bb32d2d59f71870c0a92ff6.1580147854.git.pkrempa@redhat.com

docs/formatdomaincaps.html.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

Posted by Peter Krempa 4 years, 3 months ago

The flag for the virDomainUndefine API is supported even if we report
that <backup supported='no'/>. Mention it in the docs.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/formatdomaincaps.html.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in
index aa4dece220..66e758501b 100644
--- a/docs/formatdomaincaps.html.in
+++ b/docs/formatdomaincaps.html.in
@@ -566,7 +566,10 @@

     <p>Reports whether the hypervisor supports the backup, checkpoint, and
     related features. (<code>virDomainBackupBegin</code>,
-    <code>virDomainCheckpointCreateXML</code> etc).
+    <code>virDomainCheckpointCreateXML</code> etc). The presence of the
+    <code>backup</code> element even if <code>supported='no'</code> implies that
+    the <code>VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA</code> flag for
+    <code>virDomainUndefine</code> is supported.
     </p>

     <h4><a id="elementsSEV">SEV capabilities</a></h4>
-- 
2.24.1

Re: [PATCH] docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

Posted by Pavel Hrdina 4 years, 2 months ago

On Mon, Jan 27, 2020 at 06:58:01PM +0100, Peter Krempa wrote:
> The flag for the virDomainUndefine API is supported even if we report
> that <backup supported='no'/>. Mention it in the docs.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  docs/formatdomaincaps.html.in | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

Re: [PATCH] docs: domaincaps: Mention VIR_DOMAIN_UNDEFINE_CHECKPOINTS_METADATA

Posted by Peter Krempa 4 years, 2 months ago

On Mon, Jan 27, 2020 at 18:58:01 +0100, Peter Krempa wrote:
> The flag for the virDomainUndefine API is supported even if we report
> that <backup supported='no'/>. Mention it in the docs.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  docs/formatdomaincaps.html.in | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Ping?