qemu: conf: reuse cfg->stateDir when setting cfg->swtpmStateDir

[PATCH] qemu: conf: reuse cfg->stateDir when setting cfg->swtpmStateDir

Cole Robinson via Devel posted 1 patch 1 week, 5 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/c171b6a5abf57a47a50da067ed530d854e8c25f9.1775144010.git.crobinso@redhat.com

src/qemu/qemu_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] qemu: conf: reuse cfg->stateDir when setting cfg->swtpmStateDir

Posted by Cole Robinson via Devel 1 week, 5 days ago

Use cfg->stateDir rather than duplicating it

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 src/qemu/qemu_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index b2ced2baf0..f2f9cc8a21 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -181,7 +181,7 @@ virQEMUDriverConfig *virQEMUDriverConfigNew(bool privileged,
         cfg->configBaseDir = g_strdup(SYSCONFDIR "/libvirt");
 
         cfg->stateDir = g_strdup_printf("%s/libvirt/qemu", RUNSTATEDIR);
-        cfg->swtpmStateDir = g_strdup_printf("%s/libvirt/qemu/swtpm", RUNSTATEDIR);
+        cfg->swtpmStateDir = g_strdup_printf("%s/swtpm", cfg->stateDir);
         cfg->channelTargetDir = g_strdup_printf("%s/channel", cfg->stateDir);
 
         cfg->cacheDir = g_strdup_printf("%s/cache/libvirt/qemu", LOCALSTATEDIR);
-- 
2.53.0

Re: [PATCH] qemu: conf: reuse cfg->stateDir when setting cfg->swtpmStateDir

Posted by Peter Krempa via Devel 1 week ago

On Thu, Apr 02, 2026 at 11:33:30 -0400, Cole Robinson via Devel wrote:
> Use cfg->stateDir rather than duplicating it
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  src/qemu/qemu_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>