qemuProcessQMPInit: Use long options for '-qmp' when probing qemu.

[PATCH] qemuProcessQMPInit: Use long options for '-qmp' when probing qemu.

Peter Krempa posted 1 patch 2 years, 7 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/bfe08a7689a9fb0a65ab96a588ea8f4649c98190.1631277920.git.pkrempa@redhat.com

src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] qemuProcessQMPInit: Use long options for '-qmp' when probing qemu.

Posted by Peter Krempa 2 years, 7 months ago

'-qmp' in this case behaves the same as '-chardev' so it should have
been converted the same way as others were in 43c9c0859f2d53321 since
short options are deprecated.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 207129a556..df1f481433 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -9045,7 +9045,7 @@ qemuProcessQMPInit(qemuProcessQMP *proc)

     proc->monpath = g_strdup_printf("%s/%s", proc->uniqDir, "qmp.monitor");

-    proc->monarg = g_strdup_printf("unix:%s,server,nowait", proc->monpath);
+    proc->monarg = g_strdup_printf("unix:%s,server=on,wait=off", proc->monpath);

     /*
      * Normally we'd use runDir for pid files, but because we're using
-- 
2.31.1

Re: [PATCH] qemuProcessQMPInit: Use long options for '-qmp' when probing qemu.

Posted by Ján Tomko 2 years, 7 months ago

On a Friday in 2021, Peter Krempa wrote:
>'-qmp' in this case behaves the same as '-chardev' so it should have
>been converted the same way as others were in 43c9c0859f2d53321 since
>short options are deprecated.
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano