[PATCH] bhyve: Fix version of implementation of some APIs

Michal Privoznik via Devel posted 1 patch 1 week, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/be05d685672ac87b8913b1ebb1acbf087d32ee14.1785153312.git.mprivozn@redhat.com
src/bhyve/bhyve_driver.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
[PATCH] bhyve: Fix version of implementation of some APIs
Posted by Michal Privoznik via Devel 1 week, 1 day ago
From: Michal Privoznik <mprivozn@redhat.com>

The following APIs where all implemented in 12.5.0 timeframe:

 - virDomainGetTime(), virDomainSetTime() -> v12.5.0-rc1~66
 - virDomainSetUserPassword() -> v12.5.0-rc1~65
 - virDomainAuthorizedSSHKeysGet(),
   virDomainAuthorizedSSHKeysSet() -> v12.5.0-rc1~64

But respective comments suggest they were implemented in 12.6.0
timeframe. Fix those comments.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/bhyve/bhyve_driver.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 8628a48621..4abcd70aba 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -2880,11 +2880,11 @@ static virHypervisorDriver bhyveHypervisorDriver = {
     .domainGetMemoryParameters = bhyveDomainGetMemoryParameters, /* 12.4.0 */
     .domainSetMemoryParameters = bhyveDomainSetMemoryParameters, /* 12.4.0 */
     .domainGetFSInfo = bhyveDomainGetFSInfo, /* 12.5.0 */
-    .domainGetTime = bhyveDomainGetTime, /* 12.6.0 */
-    .domainSetTime = bhyveDomainSetTime, /* 12.6.0 */
-    .domainSetUserPassword = bhyveDomainSetUserPassword, /* 12.6.0 */
-    .domainAuthorizedSSHKeysGet = bhyveDomainAuthorizedSSHKeysGet, /* 12.6.0 */
-    .domainAuthorizedSSHKeysSet = bhyveDomainAuthorizedSSHKeysSet, /* 12.6.0 */
+    .domainGetTime = bhyveDomainGetTime, /* 12.5.0 */
+    .domainSetTime = bhyveDomainSetTime, /* 12.5.0 */
+    .domainSetUserPassword = bhyveDomainSetUserPassword, /* 12.5.0 */
+    .domainAuthorizedSSHKeysGet = bhyveDomainAuthorizedSSHKeysGet, /* 12.5.0 */
+    .domainAuthorizedSSHKeysSet = bhyveDomainAuthorizedSSHKeysSet, /* 12.5.0 */
     .domainRename = bhyveDomainRename, /* 12.6.0 */
 };
 
-- 
2.54.0
Re: [PATCH] bhyve: Fix version of implementation of some APIs
Posted by Roman Bogorodskiy 1 week, 1 day ago
  Michal Privoznik via Devel wrote:

> From: Michal Privoznik <mprivozn@redhat.com>
> 
> The following APIs where all implemented in 12.5.0 timeframe:
> 
>  - virDomainGetTime(), virDomainSetTime() -> v12.5.0-rc1~66
>  - virDomainSetUserPassword() -> v12.5.0-rc1~65
>  - virDomainAuthorizedSSHKeysGet(),
>    virDomainAuthorizedSSHKeysSet() -> v12.5.0-rc1~64
> 
> But respective comments suggest they were implemented in 12.6.0
> timeframe. Fix those comments.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Oops, thanks for spotting and fixing this!

Roman
Re: [PATCH] bhyve: Fix version of implementation of some APIs
Posted by Jiri Denemark via Devel 1 week, 1 day ago
On Mon, Jul 27, 2026 at 13:55:12 +0200, Michal Privoznik wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> The following APIs where all implemented in 12.5.0 timeframe:
> 
>  - virDomainGetTime(), virDomainSetTime() -> v12.5.0-rc1~66
>  - virDomainSetUserPassword() -> v12.5.0-rc1~65
>  - virDomainAuthorizedSSHKeysGet(),
>    virDomainAuthorizedSSHKeysSet() -> v12.5.0-rc1~64
> 
> But respective comments suggest they were implemented in 12.6.0
> timeframe. Fix those comments.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/bhyve/bhyve_driver.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>