meson: Drop devmapper_dep for libvirt_admin_lib

[PATCH] meson: Drop devmapper_dep for libvirt_admin_lib

Posted by Michal Privoznik 1 week, 5 days ago

Nothing inside libvirt-admin library calls devmapper nor it
should. This is a historic artefact that was just copied over
from autotools era.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

NB, I think there are more deps that can be dropped. I've built
successfully with capng_dep, gnutls_dep, json_c_dep, libssh2_dep,
libssh_dep and sasl_dep removed. Those libraries are required by
libvirt.so which libvirt_admin.so links with.

 src/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/meson.build b/src/meson.build
index cce89fac27..74fbe43667 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -556,7 +556,6 @@ if conf.has('WITH_REMOTE')
     ],
     dependencies: [
       capng_dep,
-      devmapper_dep,
       gnutls_dep,
       json_c_dep,
       libssh2_dep,
-- 
2.45.2

Re: [PATCH] meson: Drop devmapper_dep for libvirt_admin_lib

Posted by Daniel P. Berrangé 1 week, 5 days ago

On Wed, Jan 08, 2025 at 10:56:21AM +0100, Michal Privoznik wrote:
> Nothing inside libvirt-admin library calls devmapper nor it
> should. This is a historic artefact that was just copied over
> from autotools era.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> 
> NB, I think there are more deps that can be dropped. I've built
> successfully with capng_dep, gnutls_dep, json_c_dep, libssh2_dep,
> libssh_dep and sasl_dep removed. Those libraries are required by
> libvirt.so which libvirt_admin.so links with.

Beware that on some platforms libvirt-admin.so's usage could be satisfied
indirectly by libraries libvirt.so links to, but on other platforms
libvirt-admin.so would require direct linkage. We've seen this periodically
in the past with things that link fine on Fedora, breaking on Debian/Ubuntu,
but I'm not sure if that difference in behaviour still exists today.

> 
>  src/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/meson.build b/src/meson.build
> index cce89fac27..74fbe43667 100644
> --- a/src/meson.build
> +++ b/src/meson.build
> @@ -556,7 +556,6 @@ if conf.has('WITH_REMOTE')
>      ],
>      dependencies: [
>        capng_dep,
> -      devmapper_dep,
>        gnutls_dep,
>        json_c_dep,
>        libssh2_dep,
> -- 
> 2.45.2
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] meson: Drop devmapper_dep for libvirt_admin_lib

Posted by Michal Prívozník 1 week, 5 days ago

On 1/8/25 11:04, Daniel P. Berrangé wrote:
> On Wed, Jan 08, 2025 at 10:56:21AM +0100, Michal Privoznik wrote:
>> Nothing inside libvirt-admin library calls devmapper nor it
>> should. This is a historic artefact that was just copied over
>> from autotools era.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
>>
>> NB, I think there are more deps that can be dropped. I've built
>> successfully with capng_dep, gnutls_dep, json_c_dep, libssh2_dep,
>> libssh_dep and sasl_dep removed. Those libraries are required by
>> libvirt.so which libvirt_admin.so links with.
> 
> Beware that on some platforms libvirt-admin.so's usage could be satisfied
> indirectly by libraries libvirt.so links to, but on other platforms
> libvirt-admin.so would require direct linkage. We've seen this periodically
> in the past with things that link fine on Fedora, breaking on Debian/Ubuntu,
> but I'm not sure if that difference in behaviour still exists today.

Just ran this patch through our CI and it looks like it works:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1615986790

and I totally agree with your reasoning, that's why I'm not removing any
of the other deps.

Michal