[PATCH] kbase: Document minimal libvirt version for NUMA-less virtiofs

Michal Privoznik posted 1 patch 4 years ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/b7edd742f8c89e04533066ac2d1941b90499bb63.1605215074.git.mprivozn@redhat.com
docs/kbase/virtiofs.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
[PATCH] kbase: Document minimal libvirt version for NUMA-less virtiofs
Posted by Michal Privoznik 4 years ago
Using virtiofs without NUMA was implemented in v6.9.0-rc1~161 but
our kbase document only mentions QEMU version which may confuse
users.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 docs/kbase/virtiofs.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst
index 01440420d7..c0bc07a68d 100644
--- a/docs/kbase/virtiofs.rst
+++ b/docs/kbase/virtiofs.rst
@@ -25,8 +25,9 @@ means that QEMU needs to allocate the backing memory for all the guest
 RAM as shared memory. As of QEMU 4.2, it is possible to explicitly
 specify a memory backend when specifying the NUMA topology. This
 method is however only viable for machine types that do support
-NUMA. As of QEMU 5.0.0, it is possible to specify the memory backend
-without NUMA (using the so called memobject interface).
+NUMA. As of QEMU 5.0.0 and libvirt 6.9.0, it is possible to
+specify the memory backend without NUMA (using the so called
+memobject interface).
 
 Either of the following:
 
-- 
2.26.2

Re: [PATCH] kbase: Document minimal libvirt version for NUMA-less virtiofs
Posted by Daniel Henrique Barboza 4 years ago

On 11/12/20 6:04 PM, Michal Privoznik wrote:
> Using virtiofs without NUMA was implemented in v6.9.0-rc1~161 but
> our kbase document only mentions QEMU version which may confuse
> users.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---

This is related to the IRC question just now? I've read it and wondered if
virt-install needed some tuning or something...

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   docs/kbase/virtiofs.rst | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst
> index 01440420d7..c0bc07a68d 100644
> --- a/docs/kbase/virtiofs.rst
> +++ b/docs/kbase/virtiofs.rst
> @@ -25,8 +25,9 @@ means that QEMU needs to allocate the backing memory for all the guest
>   RAM as shared memory. As of QEMU 4.2, it is possible to explicitly
>   specify a memory backend when specifying the NUMA topology. This
>   method is however only viable for machine types that do support
> -NUMA. As of QEMU 5.0.0, it is possible to specify the memory backend
> -without NUMA (using the so called memobject interface).
> +NUMA. As of QEMU 5.0.0 and libvirt 6.9.0, it is possible to
> +specify the memory backend without NUMA (using the so called
> +memobject interface).
>   
>   Either of the following:
>   
> 

Re: [PATCH] kbase: Document minimal libvirt version for NUMA-less virtiofs
Posted by Michal Privoznik 4 years ago
On 11/12/20 10:22 PM, Daniel Henrique Barboza wrote:
> 
> 
> On 11/12/20 6:04 PM, Michal Privoznik wrote:
>> Using virtiofs without NUMA was implemented in v6.9.0-rc1~161 but
>> our kbase document only mentions QEMU version which may confuse
>> users.
>>
>> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
>> ---
> 
> This is related to the IRC question just now? I've read it and wondered if
> virt-install needed some tuning or something...

Exactly! There was somebody on IRC asking why virt-install without any 
guest NUMA doesn't work.

> 
> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

Pushed, thanks.

Michal