qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive

[libvirt] [PATCH] qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive

Erik Skultety posted 1 patch 6 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/b4fad8ec16ed5c3959df4135108b544b5e44282d.1520324717.git.eskultet@redhat.com

Test syntax-check passed

src/qemu/qemu_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive

Posted by Erik Skultety 6 years, 1 month ago

Fix this common typo and assign a value rather than implicitly
type-casted comparison result. Introduced by commit b6a264e855.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---

Pushed under the trivial rule.

 src/qemu/qemu_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 96454c17c..9e715e7a0 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -7919,7 +7919,7 @@ qemuDomainUpdateDeviceLive(virDomainObjPtr vm,
         break;

     case VIR_DOMAIN_DEVICE_GRAPHICS:
-        if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics) >= 0)) {
+        if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics)) >= 0) {
             oldDev.data.graphics = vm->def->graphics[idx];
             if (virDomainDefCompatibleDevice(vm->def, dev, &oldDev) < 0)
                 return -1;
--
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive

Posted by Pavel Hrdina 6 years, 1 month ago

On Tue, Mar 06, 2018 at 09:25:45AM +0100, Erik Skultety wrote:
> Fix this common typo and assign a value rather than implicitly
> type-casted comparison result. Introduced by commit b6a264e855.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>

You could have mention this bugzilla:
<https://bugzilla.redhat.com/show_bug.cgi?id=1551687>

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list