Using check='none' when starting a domain with a CPU model marked as
usable is no longer needed as libvirt will do the right thing even with
check='partial'.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 docs/formatdomaincaps.rst | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/docs/formatdomaincaps.rst b/docs/formatdomaincaps.rst
index ef752a0f3a..1999112944 100644
--- a/docs/formatdomaincaps.rst
+++ b/docs/formatdomaincaps.rst
@@ -237,10 +237,12 @@ more details about it:
    using the CPU model and no additional feature elements. Models marked as
    usable (``usable='yes'``) can be safely used in domain XMLs with
    ``check='none'`` as the hypervisor guarantees the model can be used on the
-   current host and additional checks done by libvirt are redundant. In fact,
-   disabling libvirt checks via ``check='none'`` for such models is recommended
-   to avoid needless issues with starting domains when libvirt's definition of
-   a particular model differs from hypervisor's definition. The
+   current host and additional checks done by libvirt are redundant.
+   :since:`Since 10.2.0` libvirt automatically detects this situation and
+   avoids the redundant checks, with older releases disabling libvirt checks
+   via ``check='none'`` for such models is recommended to avoid needless
+   issues with starting domains when libvirt's definition of a particular model
+   differs from hypervisor's definition. The
    ``deprecated`` attribute reflects the hypervisor's policy on usage of this
    model :since:`(since 7.1.0)`. The ``vendor`` attribute :since:`(since 8.9.0)`
    contains the vendor of the CPU model for users who want to use CPU models
-- 
2.44.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Tue, Mar 05, 2024 at 06:15:46PM +0100, Jiri Denemark wrote:
>     using the CPU model and no additional feature elements. Models marked as
>     usable (``usable='yes'``) can be safely used in domain XMLs with
>     ``check='none'`` as the hypervisor guarantees the model can be used on the
> -   current host and additional checks done by libvirt are redundant. In fact,
> -   disabling libvirt checks via ``check='none'`` for such models is recommended
> -   to avoid needless issues with starting domains when libvirt's definition of
> -   a particular model differs from hypervisor's definition. The
> +   current host and additional checks done by libvirt are redundant.
> +   :since:`Since 10.2.0` libvirt automatically detects this situation and
> +   avoids the redundant checks, with older releases disabling libvirt checks
> +   via ``check='none'`` for such models is recommended to avoid needless
> +   issues with starting domains when libvirt's definition of a particular model
> +   differs from hypervisor's definition. The
>     ``deprecated`` attribute reflects the hypervisor's policy on usage of this
>     model :since:`(since 7.1.0)`. The ``vendor`` attribute :since:`(since 8.9.0)`
>     contains the vendor of the CPU model for users who want to use CPU models

I suggest adding

  ... avoids the redundant checks even when ``check='partial'`` is
  used, with older releases...

Either way

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org