[PATCH] docs/compiling: Add note on how to check minimum meson version

Peter Krempa posted 1 patch 3 years, 1 month ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/b38f44eed791af09df35d573c7e719b248e5e402.1615886695.git.pkrempa@redhat.com
docs/compiling.rst | 5 +++++
1 file changed, 5 insertions(+)
[PATCH] docs/compiling: Add note on how to check minimum meson version
Posted by Peter Krempa 3 years, 1 month ago
Give guidance on how to check minimum meson version for a given package.

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/140
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/compiling.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/compiling.rst b/docs/compiling.rst
index 62519b6bdb..7746f20bed 100644
--- a/docs/compiling.rst
+++ b/docs/compiling.rst
@@ -18,6 +18,11 @@ the build directory is different from the source directory:

 The *meson* script can be given options to change its default behaviour.

+**Note:** Please ensure that you have the appropriate minimal ``meson`` version
+installed in your build environment. The minimal version for a specific package
+can be checked in the top level ``meson.build`` file in the ``meson_version``
+field.
+
 To get the complete list of the options run the following command:

 ::
-- 
2.29.2

Re: [PATCH] docs/compiling: Add note on how to check minimum meson version
Posted by Erik Skultety 3 years, 1 month ago
On Tue, Mar 16, 2021 at 10:24:55AM +0100, Peter Krempa wrote:
> Give guidance on how to check minimum meson version for a given package.
> 
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/140
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>

facepalm...the whole point of the conversion of this file to RST was to close
the issue..and then I forgot about it.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

Re: [PATCH] docs/compiling: Add note on how to check minimum meson version
Posted by Michal Privoznik 3 years, 1 month ago
On 3/16/21 10:24 AM, Peter Krempa wrote:
> Give guidance on how to check minimum meson version for a given package.
> 
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/140
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   docs/compiling.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal