[PATCH] man: virt-admin: Remove misleading paragraph about unix socket permissions

Peter Krempa posted 1 patch 2 years, 3 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/b36380b665276cce815eb4ae03dab95d2de1c38e.1642699262.git.pkrempa@redhat.com
docs/manpages/virt-admin.rst | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
[PATCH] man: virt-admin: Remove misleading paragraph about unix socket permissions
Posted by Peter Krempa 2 years, 3 months ago
The socket permissions are controlled by 'unix_sock_admin_perms', but
regardless the code requires that 'geteuid() != clientuid' to allow
clients thus it doesn't make sense to make users aware of it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 docs/manpages/virt-admin.rst | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst
index 940a38bfce..fff65cf9a7 100644
--- a/docs/manpages/virt-admin.rst
+++ b/docs/manpages/virt-admin.rst
@@ -91,11 +91,7 @@ NOTES
 =====

 Running ``virt-admin`` requires root privileges due to the
-communications channels used to talk to the daemon. Consider changing the
-*unix_sock_group* ownership setting to grant access to specific set of users
-or modifying *unix_sock_rw_perms* permissions. Daemon configuration file
-provides more information about setting permissions.
-
+communications channels used to talk to the daemon.

 GENERIC COMMANDS
 ================
-- 
2.34.1

Re: [PATCH] man: virt-admin: Remove misleading paragraph about unix socket permissions
Posted by Daniel P. Berrangé 2 years, 3 months ago
On Thu, Jan 20, 2022 at 06:21:02PM +0100, Peter Krempa wrote:
> The socket permissions are controlled by 'unix_sock_admin_perms', but
> regardless the code requires that 'geteuid() != clientuid' to allow
> clients thus it doesn't make sense to make users aware of it.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  docs/manpages/virt-admin.rst | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|