schema: make target mandatory for filesystems

[libvirt PATCH] schema: make target mandatory for filesystems

Ján Tomko posted 1 patch 2 years, 8 months ago

Download mbox

Test syntax-check failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/ab3afa5e9075b9eb7db9af41f761fbc72efd8ec5.1627384381.git.jtomko@redhat.com

docs/schemas/domaincommon.rng | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

Expand all Fold all

[libvirt PATCH] schema: make target mandatory for filesystems

Posted by Ján Tomko 2 years, 8 months ago

Commit 12967c3e13 incorrectly made the target optional.
The validation was re-introduced by commit e8863b91f (which
put it into FSDefValidate instead of the parser), but
it did not amend the schema to make it mandatory again.

https://bugzilla.redhat.com/show_bug.cgi?id=1969232

Fixes: e8863b91fb98f077d4c44a11bd7ea84c5e6b29ef
Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 docs/schemas/domaincommon.rng | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 14c5d4ee68..2442078969 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -2859,12 +2859,10 @@
           </group>
         </choice>
         <interleave>
-          <optional>
-            <element name="target">
-              <attribute name="dir"/>
-              <empty/>
-            </element>
-          </optional>
+          <element name="target">
+            <attribute name="dir"/>
+            <empty/>
+          </element>
           <optional>
             <attribute name="accessmode">
               <choice>
-- 
2.31.1