Introduced in v1.0.6~3, the idea was that unit 7 was reserved and
couldn't be used by QEMU. Well, that limitation is long gone.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
src/conf/domain_conf.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b7a342bb91..6a019490fd 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -4812,12 +4812,6 @@ bool
virDomainSCSIDriveAddressIsUsed(const virDomainDef *def,
const virDomainDeviceDriveAddress *addr)
{
- /* In current implementation, the maximum unit number of a controller
- * is either 16 or 7 (narrow SCSI bus), and if the maximum unit number
- * is 16, the controller itself is on unit 7 */
- if (addr->unit == 7)
- return true;
-
if (virDomainDriveAddressIsUsedByDisk(def, VIR_DOMAIN_DISK_BUS_SCSI,
addr) ||
virDomainDriveAddressIsUsedByHostdev(def,
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On 8/28/19 11:52 AM, Michal Privoznik wrote: > Ping. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Aug 28, 2019 at 11:52:45AM +0200, Michal Privoznik wrote: >Introduced in v1.0.6~3, the idea was that unit 7 was reserved and >couldn't be used by QEMU. Well, that limitation is long gone. > How does "long gone" translate to our platform support matrix? Jano >Signed-off-by: Michal Privoznik <mprivozn@redhat.com> >--- > src/conf/domain_conf.c | 6 ------ > 1 file changed, 6 deletions(-) > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 9/10/19 3:05 PM, Ján Tomko wrote: > On Wed, Aug 28, 2019 at 11:52:45AM +0200, Michal Privoznik wrote: >> Introduced in v1.0.6~3, the idea was that unit 7 was reserved and >> couldn't be used by QEMU. Well, that limitation is long gone. >> > > How does "long gone" translate to our platform support matrix? > So this got me thinking and experimenting and researching. The code as-is now is partially correct but only for vmware controller models. virtio-scsi for instance doesn't have this limitation. So I'll be sending a v2 that refines this check. Hopefully, it'll be correct this time. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 8/28/19 6:52 AM, Michal Privoznik wrote:
> Introduced in v1.0.6~3, the idea was that unit 7 was reserved and
> couldn't be used by QEMU. Well, that limitation is long gone.
>
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> src/conf/domain_conf.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index b7a342bb91..6a019490fd 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -4812,12 +4812,6 @@ bool
> virDomainSCSIDriveAddressIsUsed(const virDomainDef *def,
> const virDomainDeviceDriveAddress *addr)
> {
> - /* In current implementation, the maximum unit number of a controller
> - * is either 16 or 7 (narrow SCSI bus), and if the maximum unit number
> - * is 16, the controller itself is on unit 7 */
> - if (addr->unit == 7)
> - return true;
> -
> if (virDomainDriveAddressIsUsedByDisk(def, VIR_DOMAIN_DISK_BUS_SCSI,
> addr) ||
> virDomainDriveAddressIsUsedByHostdev(def,
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2026 Red Hat, Inc.