[libvirt] [PATCH] docs: news: Add entries for my recent changes

Peter Krempa posted 1 patch 6 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/a7d8b0481ab4b680fb5a171946cee8181d114cc1.1498634754.git.pkrempa@redhat.com
There is a newer version of this series
docs/news.xml | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
[libvirt] [PATCH] docs: news: Add entries for my recent changes
Posted by Peter Krempa 6 years, 9 months ago
---
 docs/news.xml | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 27562e12b..f0c902fa4 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -48,8 +48,40 @@
       </change>
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          block copy job can be used with persistent domains
+        </summary>
+        <description>
+          Users who can tolerate that the block copy job might not be recovered
+          if a VM is shutdown until it finishes now may specify the
+          VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB flag to make block copy work for
+          persistent VMs too.
+        </description>
+      </change>
+      <change>
+        <summary>
+          JSON pseudo-protocol backing store parser supports new format of qemu 2.9
+        </summary>
+        <description>
+          QEMU 2.9 modified a few structures corresponding to the JSON format
+          of specifying a backing store for a disk image. Libvirt now implements
+          the new format.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          block commit is now able to keep relative backing chain after snapshot again
+        </summary>
+        <description>
+          An external snapshot created with VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT
+          would not be scanned for metadata and thus if users specified a
+          relative path to the backing image this would not be detected. Block
+          commit operation then was unable to keep the relative relationship.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v3.4.0" date="2017-06-02">
-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] docs: news: Add entries for my recent changes
Posted by Martin Kletzander 6 years, 9 months ago
On Wed, Jun 28, 2017 at 09:25:54AM +0200, Peter Krempa wrote:
>---
> docs/news.xml | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
>diff --git a/docs/news.xml b/docs/news.xml
>index 27562e12b..f0c902fa4 100644
>--- a/docs/news.xml
>+++ b/docs/news.xml
>@@ -48,8 +48,40 @@
>       </change>
>     </section>
>     <section title="Improvements">
>+      <change>
>+        <summary>
>+          block copy job can be used with persistent domains
>+        </summary>
>+        <description>
>+          Users who can tolerate that the block copy job might not be recovered
>+          if a VM is shutdown until it finishes now may specify the

Don't you mean s/until/before/ here?  It would be easier to know if the
whole description wasn't one super long sentence with bunch of
sub-sentences and no commas.

>+          VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB flag to make block copy work for
>+          persistent VMs too.
>+        </description>
>+      </change>
>+      <change>
>+        <summary>
>+          JSON pseudo-protocol backing store parser supports new format of qemu 2.9
>+        </summary>
>+        <description>
>+          QEMU 2.9 modified a few structures corresponding to the JSON format
>+          of specifying a backing store for a disk image. Libvirt now implements
>+          the new format.
>+        </description>
>+      </change>
>     </section>
>     <section title="Bug fixes">
>+      <change>
>+        <summary>
>+          block commit is now able to keep relative backing chain after snapshot again
>+        </summary>
>+        <description>
>+          An external snapshot created with VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT
>+          would not be scanned for metadata and thus if users specified a
>+          relative path to the backing image this would not be detected. Block
>+          commit operation then was unable to keep the relative relationship.

s/then was/was then/ or even better: "was unable to keep the
(relative) relationship in that case."

If you insist on the structure (without any commas or parentheses), then
at least execute the replacements and ACK to that.  I won't be against
v2 or a proposed squash-in, though ;)

>+        </description>
>+      </change>
>     </section>
>   </release>
>   <release version="v3.4.0" date="2017-06-02">
>--
>2.12.2
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
[libvirt] [PATCH v2] docs: news: Add entries for my recent changes
Posted by Peter Krempa 6 years, 9 months ago
---
 docs/news.xml | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/docs/news.xml b/docs/news.xml
index 27562e12b..f4423a646 100644
--- a/docs/news.xml
+++ b/docs/news.xml
@@ -48,8 +48,42 @@
       </change>
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          qemu: block copy job can be used with persistent domains
+        </summary>
+        <description>
+          Until now it was not possible to use block copy with persistent VMs.
+          In use cases where it's not required to recover the job after VM
+          shutdown, it's possible to specify VIR_DOMAIN_BLOCK_COPY_TRANSIENT_JOB
+          flag to start the copy job.
+        </description>
+      </change>
+      <change>
+        <summary>
+          JSON pseudo-protocol backing store parser supports new format of qemu 2.9
+        </summary>
+        <description>
+          QEMU 2.9 modified a few structures corresponding to the JSON format
+          of specifying a backing store for a disk image. Libvirt now implements
+          the new format.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          qemu: snapshot: retrieve image metadata from user provided files
+        </summary>
+        <description>
+          Disk images of an external snapshot created with
+          VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT flag specified would not be
+          scanned for metadata after recent changes.
+
+          The metadata is necessary to allow keeping relative paths between
+          images when doing a block-commit.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v3.4.0" date="2017-06-02">
-- 
2.12.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2] docs: news: Add entries for my recent changes
Posted by Martin Kletzander 6 years, 9 months ago
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list