[libvirt] [PATCH] docs: storage: owner/group default to libvirtd UID/GID

Cole Robinson posted 1 patch 39 weeks ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/a3996c6078c3a233c676f1cebeee2010d9c17802.1549496206.git.crobinso@redhat.com
docs/formatstorage.html.in | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

[libvirt] [PATCH] docs: storage: owner/group default to libvirtd UID/GID

Posted by Cole Robinson 39 weeks ago
Commit fafcc818f changed the docs to say that when creating a
pool directory or file volume with no owner/group specified, they
will be inherited from the parent directory. This isn't correct
now and doesn't seem to have ever been correct

In reality default owner/group is whatever UID/GID libvirtd is
running as

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 docs/formatstorage.html.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
index 6ebd23549f..968651330f 100644
--- a/docs/formatstorage.html.in
+++ b/docs/formatstorage.html.in
@@ -478,8 +478,8 @@
         The <code>owner</code> element contains the numeric user ID.
         The <code>group</code> element contains the numeric group ID.
         If <code>owner</code> or <code>group</code> aren't specified when
-        creating a directory, the values are inherited from the parent
-        directory. The <code>label</code> element contains the MAC (eg SELinux)
+        creating a directory, the UID and GID of the libvirtd process are used.
+        The <code>label</code> element contains the MAC (eg SELinux)
         label string.
         <span class="since">Since 0.4.1</span>
         For running directory or filesystem based pools, these fields
@@ -776,8 +776,8 @@
         The <code>owner</code> element contains the numeric user ID.
         The <code>group</code> element contains the numeric group ID.
         If <code>owner</code> or <code>group</code> aren't specified when
-        creating a supported volume, the values are inherited from the parent
-        directory. The <code>label</code> element contains the MAC (eg SELinux)
+        creating a supported volume, the UID and GID of the libvirtd process
+        are used. The <code>label</code> element contains the MAC (eg SELinux)
         label string.
         For existing directory or filesystem based volumes, these fields
         will be filled with the values used by the existing file.
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] docs: storage: owner/group default to libvirtd UID/GID

Posted by Michal Privoznik 39 weeks ago
On 2/7/19 12:36 AM, Cole Robinson wrote:
> Commit fafcc818f changed the docs to say that when creating a
> pool directory or file volume with no owner/group specified, they
> will be inherited from the parent directory. This isn't correct
> now and doesn't seem to have ever been correct
> 
> In reality default owner/group is whatever UID/GID libvirtd is
> running as
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>   docs/formatstorage.html.in | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list