ch: Include unistd.h in ch_events.c

[PATCH] ch: Include unistd.h in ch_events.c

Michal Privoznik posted 1 patch 7 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/9d21246d703f28f87dacb7ba2de5e2814bda7694.1737994415.git.mprivozn@redhat.com

src/ch/ch_events.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] ch: Include unistd.h in ch_events.c

Posted by Michal Privoznik 7 months, 2 weeks ago

There's a call to read() in the file but corresponding include of
unistd.h is missing causing a build failure.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

Green pipeline:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1642845347

 src/ch/ch_events.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/ch/ch_events.c b/src/ch/ch_events.c
index ba5b247c83..1cce30836a 100644
--- a/src/ch/ch_events.c
+++ b/src/ch/ch_events.c
@@ -20,6 +20,8 @@
 
 #include <config.h>
 
+#include <unistd.h>
+
 #include "ch_domain.h"
 #include "ch_events.h"
 #include "ch_process.h"
-- 
2.45.2

Re: [PATCH] ch: Include unistd.h in ch_events.c

Posted by Pavel Hrdina 7 months, 2 weeks ago

On Mon, Jan 27, 2025 at 05:14:00PM +0100, Michal Privoznik wrote:
> There's a call to read() in the file but corresponding include of
> unistd.h is missing causing a build failure.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
> 
> Green pipeline:
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1642845347
> 
>  src/ch/ch_events.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>