virDomainDefPostParse: use DOMAIN_DEVICE_ITERATE_MISSING_INFO

[libvirt] [PATCH] virDomainDefPostParse: use DOMAIN_DEVICE_ITERATE_MISSING_INFO

Ján Tomko posted 1 patch 4 years, 11 months ago

Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/9bc91ceab35bdc106769637aa74c3b0dcac873c7.1558615376.git.jtomko@redhat.com

src/conf/domain_conf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] virDomainDefPostParse: use DOMAIN_DEVICE_ITERATE_MISSING_INFO

Posted by Ján Tomko 4 years, 11 months ago

Apart from virDomainDefValidate, virDomainDefPostParse is another
place where operating on info-less devices makes sense.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/conf/domain_conf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 926c2139b7..006920e954 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -5803,7 +5803,8 @@ virDomainDefPostParse(virDomainDefPtr def,
     /* iterate the devices */
     ret = virDomainDeviceInfoIterateInternal(def,
                                              virDomainDefPostParseDeviceIterator,
-                                             DOMAIN_DEVICE_ITERATE_ALL_CONSOLES,
+                                             DOMAIN_DEVICE_ITERATE_ALL_CONSOLES |
+                                             DOMAIN_DEVICE_ITERATE_MISSING_INFO,
                                              &data);
 
     if (virDomainDefPostParseCheckFailure(def, parseFlags, ret) < 0)
-- 
2.19.2

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virDomainDefPostParse: use DOMAIN_DEVICE_ITERATE_MISSING_INFO

Posted by Andrea Bolognani 4 years, 11 months ago

On Thu, 2019-05-23 at 14:43 +0200, Ján Tomko wrote:
> Apart from virDomainDefValidate, virDomainDefPostParse is another
> place where operating on info-less devices makes sense.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/conf/domain_conf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

ACK

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list