[v1] NEWS: Document features/improvements/bug fixes I've participated in

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in

Posted by Michal Privoznik 3 months ago

There are some features/improvements/bug fixes I've either
contributed or reviewed/merged. Document them for upcoming
release.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 NEWS.rst | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index 17335b3f6e..1a320c5442 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -28,8 +28,42 @@ v10.6.0 (unreleased)
 
 * **Improvements**
 
+  * qemu: Set 'passt' net backend if 'default' is unsupported
+
+    If QEMU is compiled without SLIRP support, and if domain XML allows it,
+    starting from this release libvirt will use passt as the default backend
+    instead. Also, supported backends are now reported in the domain
+    capabilities XML.
+
+  * qemu: Require QEMU-5.2.0 or newer
+
+    The minimal required version of QEMU was bumped to 5.2.0.
+
+  * qemu: add a monitor to /proc/$pid when killing times out
+
+    In cases when a QEMU process takes longer to be killed, libvirt might have
+    skipped cleaning up after it. But now a /proc/$pid watch is installed so
+    this does not happen ever again.
+
 * **Bug fixes**
 
+  * virt-aa-helper: Allow RO access to /usr/share/edk2-ovmf
+
+    When binary version of edk2 is distributed, the files reside under
+    /usr/share/edk2-ovmf. Allow virt-aa-helper to generate paths under that
+    directory.
+
+  * virt-host-validate: Allow longer list of CPU flags
+
+    During its run, virt-host-validate parses /proc/cpuinfo to learn about CPU
+    flags. But due to a bug it parsed only the first 1024 bytes worth of CPU
+    flags leading to unexpected results. The file is now parsed properly.
+
+  * capabilities: Be more forgiving when decoding OEM strings
+
+    On some systems, OEM strings are scattered in multiple sections. This
+    confused libvirt when generating capabilities XML. Not anymore.
+
 
 v10.5.0 (2024-07-01)
 ====================
-- 
2.44.2

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

Posted by Boris Fiuczynski 3 months ago

On 7/30/24 6:46 AM, Michal Privoznik wrote:
> There are some features/improvements/bug fixes I've either
> contributed or reviewed/merged. Document them for upcoming
> release.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>   NEWS.rst | 34 ++++++++++++++++++++++++++++++++++
>   1 file changed, 34 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 17335b3f6e..1a320c5442 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -28,8 +28,42 @@ v10.6.0 (unreleased)
>   
>   * **Improvements**
>   
> +  * qemu: Set 'passt' net backend if 'default' is unsupported
> +
> +    If QEMU is compiled without SLIRP support, and if domain XML allows it,
> +    starting from this release libvirt will use passt as the default backend
> +    instead. Also, supported backends are now reported in the domain
> +    capabilities XML.
> +
> +  * qemu: Require QEMU-5.2.0 or newer
> +
> +    The minimal required version of QEMU was bumped to 5.2.0.
> +
> +  * qemu: add a monitor to /proc/$pid when killing times out
> +
> +    In cases when a QEMU process takes longer to be killed, libvirt might have
> +    skipped cleaning up after it. But now a /proc/$pid watch is installed so
> +    this does not happen ever again.
...ever ever?... :D

Thanks.
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>


> +
>   * **Bug fixes**
>   
> +  * virt-aa-helper: Allow RO access to /usr/share/edk2-ovmf
> +
> +    When binary version of edk2 is distributed, the files reside under
> +    /usr/share/edk2-ovmf. Allow virt-aa-helper to generate paths under that
> +    directory.
> +
> +  * virt-host-validate: Allow longer list of CPU flags
> +
> +    During its run, virt-host-validate parses /proc/cpuinfo to learn about CPU
> +    flags. But due to a bug it parsed only the first 1024 bytes worth of CPU
> +    flags leading to unexpected results. The file is now parsed properly.
> +
> +  * capabilities: Be more forgiving when decoding OEM strings
> +
> +    On some systems, OEM strings are scattered in multiple sections. This
> +    confused libvirt when generating capabilities XML. Not anymore.
> +
>   
>   v10.5.0 (2024-07-01)
>   ====================

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

Re: [PATCH] NEWS: Document features/improvements/bug fixes I've participated in

Posted by Peter Krempa 3 months ago

On Tue, Jul 30, 2024 at 06:46:14 +0200, Michal Privoznik wrote:
> There are some features/improvements/bug fixes I've either
> contributed or reviewed/merged. Document them for upcoming
> release.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  NEWS.rst | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index 17335b3f6e..1a320c5442 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -28,8 +28,42 @@ v10.6.0 (unreleased)
>  
>  * **Improvements**
>  
> +  * qemu: Set 'passt' net backend if 'default' is unsupported
> +
> +    If QEMU is compiled without SLIRP support, and if domain XML allows it,
> +    starting from this release libvirt will use passt as the default backend
> +    instead. Also, supported backends are now reported in the domain
> +    capabilities XML.
> +
> +  * qemu: Require QEMU-5.2.0 or newer
> +
> +    The minimal required version of QEMU was bumped to 5.2.0.

I'd argue that this entry belongs under "Removed features"

> +
> +  * qemu: add a monitor to /proc/$pid when killing times out
> +
> +    In cases when a QEMU process takes longer to be killed, libvirt might have
> +    skipped cleaning up after it. But now a /proc/$pid watch is installed so
> +    this does not happen ever again.
> +
>  * **Bug fixes**
>  
> +  * virt-aa-helper: Allow RO access to /usr/share/edk2-ovmf
> +
> +    When binary version of edk2 is distributed, the files reside under
> +    /usr/share/edk2-ovmf. Allow virt-aa-helper to generate paths under that
> +    directory.
> +
> +  * virt-host-validate: Allow longer list of CPU flags
> +
> +    During its run, virt-host-validate parses /proc/cpuinfo to learn about CPU
> +    flags. But due to a bug it parsed only the first 1024 bytes worth of CPU
> +    flags leading to unexpected results. The file is now parsed properly.
> +
> +  * capabilities: Be more forgiving when decoding OEM strings
> +
> +    On some systems, OEM strings are scattered in multiple sections. This
> +    confused libvirt when generating capabilities XML. Not anymore.
> +

Reviewed-by: Peter Krempa <pkrempa@redhat.com>