[PATCH] github: Update lockdown message when openin a PR

Michal Privoznik posted 1 patch 6 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/9726634217202338a613cdc2351d325fa529acee.1715329301.git.mprivozn@redhat.com
.github/workflows/lockdown.yml | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
[PATCH] github: Update lockdown message when openin a PR
Posted by Michal Privoznik 6 months, 2 weeks ago
The message that's thrown at users when they try to open a pull
request on github suggests opening the MR on gitlab instead.
While this works for other libvirt subprojects, for the main
libvirt.git we still use e-mail workflow. Update the message to
reflect this fact.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 .github/workflows/lockdown.yml | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
index 74931a2944..69c0b8eb38 100644
--- a/.github/workflows/lockdown.yml
+++ b/.github/workflows/lockdown.yml
@@ -39,13 +39,10 @@ jobs:
             repostory hosted on GitLab, merge requests opened here are not
             processed.
 
-            We kindly request that contributors fork the project at
+            For main libvirt.git repository all patch review and discussion
+            only occurs on the devel mailing list.
 
-              https://gitlab.com/libvirt/libvirt/
-
-            push changes to the fork, and then open a new merge request at
-
-              https://gitlab.com/libvirt/libvirt/-/merge_requests/new
+              https://libvirt.org/submitting-patches.html
 
             Thank you for your time and understanding.
           lock-pr: true
-- 
2.43.2
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org
Re: [PATCH] github: Update lockdown message when openin a PR
Posted by Martin Kletzander 6 months, 1 week ago
On Fri, May 10, 2024 at 10:21:41AM +0200, Michal Privoznik wrote:
>The message that's thrown at users when they try to open a pull
>request on github suggests opening the MR on gitlab instead.
>While this works for other libvirt subprojects, for the main
>libvirt.git we still use e-mail workflow. Update the message to
>reflect this fact.
>
>Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>---
> .github/workflows/lockdown.yml | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
>index 74931a2944..69c0b8eb38 100644
>--- a/.github/workflows/lockdown.yml
>+++ b/.github/workflows/lockdown.yml
>@@ -39,13 +39,10 @@ jobs:
>             repostory hosted on GitLab, merge requests opened here are not
>             processed.
>
>-            We kindly request that contributors fork the project at
>+            For main libvirt.git repository all patch review and discussion
>+            only occurs on the devel mailing list.
>
>-              https://gitlab.com/libvirt/libvirt/
>-
>-            push changes to the fork, and then open a new merge request at
>-
>-              https://gitlab.com/libvirt/libvirt/-/merge_requests/new
>+              https://libvirt.org/submitting-patches.html
>
>             Thank you for your time and understanding.
>           lock-pr: true
>-- 
>2.43.2
>_______________________________________________
>Devel mailing list -- devel@lists.libvirt.org
>To unsubscribe send an email to devel-leave@lists.libvirt.org