ci: potfiles: Add 'variables' to definition

[PATCH] ci: potfiles: Add 'variables' to definition

Posted by Peter Krempa 1 year, 6 months ago

The 'potfiles' job is lacking the 'variables' section which defines the
'NAME' variable used by the 'image' property resulting in the 'potfiles'
job failing with:

 Pulling docker image registry.gitlab.com/libvirt/libvirt/ci-:latest ...
 WARNING: Failed to pull image with policy "always": invalid reference format (manager.go:235:0s)
 ERROR: Job failed: failed to pull image "registry.gitlab.com/libvirt/libvirt/ci-:latest" with specified policies [always]: invalid reference format (manager.go:235:0s)

Fixes: 491d918502e50bf15c75d183bb41e3c0de5a0e1b
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 .gitlab-ci.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c05155ddd4..1b72ebc493 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -138,6 +138,8 @@ codestyle_local_env:
 potfile:
   image: $CI_REGISTRY/$RUN_UPSTREAM_NAMESPACE/libvirt/ci-$NAME:latest
   stage: builds
+  variables:
+    NAME: almalinux-8
   before_script:
     - cat /packages.txt
   needs:
-- 
2.37.3

Re: [PATCH] ci: potfiles: Add 'variables' to definition

Posted by Ján Tomko 1 year, 6 months ago

On a Tuesday in 2022, Peter Krempa wrote:
>The 'potfiles' job is lacking the 'variables' section which defines the
>'NAME' variable used by the 'image' property resulting in the 'potfiles'
>job failing with:
>
> Pulling docker image registry.gitlab.com/libvirt/libvirt/ci-:latest ...
> WARNING: Failed to pull image with policy "always": invalid reference format (manager.go:235:0s)
> ERROR: Job failed: failed to pull image "registry.gitlab.com/libvirt/libvirt/ci-:latest" with specified policies [always]: invalid reference format (manager.go:235:0s)
>
>Fixes: 491d918502e50bf15c75d183bb41e3c0de5a0e1b
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano

Re: [PATCH] ci: potfiles: Add 'variables' to definition

Posted by Peter Krempa 1 year, 6 months ago

On Tue, Oct 11, 2022 at 09:38:17 +0200, Peter Krempa wrote:
> The 'potfiles' job is lacking the 'variables' section which defines the
> 'NAME' variable used by the 'image' property resulting in the 'potfiles'
> job failing with:
> 
>  Pulling docker image registry.gitlab.com/libvirt/libvirt/ci-:latest ...
>  WARNING: Failed to pull image with policy "always": invalid reference format (manager.go:235:0s)
>  ERROR: Job failed: failed to pull image "registry.gitlab.com/libvirt/libvirt/ci-:latest" with specified policies [always]: invalid reference format (manager.go:235:0s)
> 
> Fixes: 491d918502e50bf15c75d183bb41e3c0de5a0e1b
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---

CI job with this patch plus a patch hacking around so that the job is
run in my fork:

https://gitlab.com/pipo.sk/libvirt/-/jobs/3154252403