The %{release} part of the requirement is just wrong as python bindings
are not rebuilt anytime libvirt release is increased, which means the
client-qemu package may require nonexistent release of python bindings.

The %{version} part is not wrong, but it's too strict for no reason as
the virt-qemu-qmp-proxy script will work happily even with ancient
python bindings. And since all distros supported by libvirt.spec already
contain python3-libvirt, we can depend on the first package called this
way.

tigned-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 libvirt.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index d946a8da48..0bbcdb8956 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -906,7 +906,7 @@ capabilities of recent versions of Linux (and other OSes).
 %package client-qemu
 Summary: Additional client side utilities for QEMU
 Requires: %{name}-libs = %{version}-%{release}
-Requires: python3-libvirt >= %{version}-%{release}
+Requires: python3-libvirt >= 3.7.0
 
 %description client-qemu
 The additional client binaries are used to interact
-- 
2.38.1

On Wed, Nov 02, 2022 at 01:32:00PM +0100, Jiri Denemark wrote:
> The %{release} part of the requirement is just wrong as python bindings
> are not rebuilt anytime libvirt release is increased, which means the
> client-qemu package may require nonexistent release of python bindings.
> 
> The %{version} part is not wrong, but it's too strict for no reason as
> the virt-qemu-qmp-proxy script will work happily even with ancient
> python bindings. And since all distros supported by libvirt.spec already
> contain python3-libvirt, we can depend on the first package called this
> way.
> 
> tigned-off-by: Jiri Denemark <jdenemar@redhat.com>

typo

> ---
>  libvirt.spec.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|